Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test using windows OSVersion #5115

Open
tonistiigi opened this issue Jul 2, 2024 · 2 comments · May be fixed by #5614
Open

Add test using windows OSVersion #5115

tonistiigi opened this issue Jul 2, 2024 · 2 comments · May be fixed by #5614
Assignees
@profnandaa
Labels
area/testing area/windows

Comments

@tonistiigi
Copy link
Member

With #5034 platforms packages supports OSVersion component in platform string. We should add a test that sets custom OSVersion in --platform and verifies it in the output image. Note that the test does not need to be WCOW test, it can just be something with FROM scratch && COPY

cc @profnandaa
@tonistiigi
Copy link
Member Author

Later we can also build a couple of images with various OSVersion, push to local test registry, and then check that FROM pulls the expected one based on input parameters.

@profnandaa
Copy link
Collaborator

ACK.

@profnandaa profnandaa self-assigned this Jul 2, 2024
@cpuguy83 cpuguy83 linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@profnandaa profnandaa

Labels
area/testing area/windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Support OS version in platform string cpuguy83/buildkit
2 participants
@profnandaa @tonistiigi