Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DEPRECATION NOTICE from rake spec run #13

Open
trystant opened this issue Dec 1, 2019 · 1 comment
Open

Remove DEPRECATION NOTICE from rake spec run #13

trystant opened this issue Dec 1, 2019 · 1 comment
Labels
low priority

Comments

@trystant
Copy link
Collaborator

trystant commented Dec 1, 2019 •
edited
Loading

A rake run on this project results in a deprecation notice showing up in the logs:

NOTE: Inheriting Faraday::Error::ClientError is deprecated; use Faraday::ClientError instead. It will be removed in or after version 1.0
Faraday::Error::ClientError.inherited called from /home/mnyon/.rvm/gems/ruby-2.5.5@github-valet/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14.

This should be removed from rake output.
@trystant
Copy link
Collaborator Author

trystant commented Dec 1, 2019

I had thought that this would be fixed by removing the error from the octokit gem, but this is more of a function of this gem, so let's take a deeper look here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trystant