Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypng is an unlisted dependency #65

Open
rpdelaney opened this issue Aug 31, 2018 · 5 comments
Open

pypng is an unlisted dependency #65

rpdelaney opened this issue Aug 31, 2018 · 5 comments

Comments

@rpdelaney
Copy link

Pretty much the subject.

I installed this with pip3 install --user pyqrcode but got hit with module not found on line 1266 of builder.py: import png. The comments to that file state that pypng is required, so I installed that the same way I installed pyqrcode and now it works.

@agroszer
Copy link

Is this intentional? Just add pypng to setup.py install_requires please

@heuer
Copy link
Contributor

heuer commented Mar 28, 2019

We discussed it in the past since I wanted pypng as requirement but Michael said PNG is just one serialization format and wanted to keep it as optional dependency because all other formats work without further dependencies.

It's listed in the setup an extra:

 extras_require = {
   'PNG':  ["pypng>=0.0.13"],

},

To cut a long story short: Yes, it is intentional. ;)

@agroszer
Copy link

ok, thx

@rpdelaney
Copy link
Author

Optional is fine, but we should consider handling the ImportError, perhaps with a more user-friendly message.

@heuer
Copy link
Contributor

heuer commented Mar 28, 2019

I agree, anyway we cannot do anything about it; see #52

And without solving pypi/warehouse#4121 I am not in the mood to invest any more energy into this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants