Refactor

Author: GuillaumeFavelier

mne/viz/_brain/_brain.py

@@ -3065,9 +3065,6 @@ def _post_setup(unused):
                 dialog.finished.connect(_post_setup)
                 return dialog
             else:
-                from PyQt5.QtCore import Qt
-                from PyQt5.QtGui import QCursor
-
                 def frame_callback(frame, n_frames):
                     if frame == n_frames:
                         # On the ImageIO step
@@ -3094,7 +3091,8 @@ def frame_callback(frame, n_frames):
 
                 # set cursor to busy
                 default_cursor = self._renderer._window_get_cursor()
-                self._renderer._window_set_cursor(QCursor(Qt.WaitCursor))
+                self._renderer._window_set_cursor(
+                    self._renderer._window_new_cursor("WaitCursor"))
 
                 try:
                     self._save_movie(

mne/viz/backends/_abstract.py

@@ -789,6 +789,10 @@ def _window_get_cursor(self):
     def _window_set_cursor(self, cursor):
         pass
 
+    @abstractmethod
+    def _window_new_cursor(self, name):
+        pass
+
     @abstractmethod
     def _window_ensure_minimum_sizes(self):
         pass

mne/viz/backends/_notebook.py

@@ -282,6 +282,9 @@ def _window_get_cursor(self):
     def _window_set_cursor(self, cursor):
         pass
 
+    def _window_new_cursor(self, name):
+        pass
+
     @contextmanager
     def _window_ensure_minimum_sizes(self):
         yield

mne/viz/backends/_qt.py

@@ -14,7 +14,7 @@
     from pyvistaqt.plotting import FileDialog
 
 from PyQt5.QtCore import Qt, pyqtSignal, QLocale
-from PyQt5.QtGui import QIcon, QImage, QPixmap
+from PyQt5.QtGui import QIcon, QImage, QPixmap, QCursor
 from PyQt5.QtWidgets import (QComboBox, QDockWidget, QDoubleSpinBox, QGroupBox,
                              QHBoxLayout, QLabel, QToolButton, QMenuBar,
                              QSlider, QSpinBox, QVBoxLayout, QWidget,
@@ -403,6 +403,9 @@ def _window_get_cursor(self):
     def _window_set_cursor(self, cursor):
         self._interactor.setCursor(cursor)
 
+    def _window_new_cursor(self, name):
+        return QCursor(getattr(Qt, name))
+
     @contextmanager
     def _window_ensure_minimum_sizes(self):
         sz = self.figure.store['window_size']