Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mermaid link, install instructions #61

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mnbf9rca
Copy link
Owner

@mnbf9rca mnbf9rca commented Jul 23, 2024

Summary by Sourcery

This pull request updates the README documentation to improve installation instructions, clarify response object properties related to caching, and provide an online link for the Mermaid visualisation of the Pydantic models.

  • Documentation:
    • Updated installation instructions to include both pip and poetry commands.
    • Clarified the properties content_expires and shared_expires in the response objects, explaining their calculation and usage for caching.
    • Added a link to view the Mermaid visualisation of the Pydantic models online.

Copy link

sourcery-ai bot commented Jul 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the README.md file to correct the installation instructions, add an alternative installation method using Poetry, and provide more detailed information about the content_expires and shared_expires properties. Additionally, it updates the Mermaid visualisation section to include a link to view the diagram online.

File-Level Changes

Files Changes
README.md Updated installation instructions, added alternative installation method, provided more details on content_expires and shared_expires properties, and included a link to view the Mermaid visualisation online.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@mnbf9rca mnbf9rca merged commit 71e4d73 into main Jul 23, 2024
5 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Can you clarify if the change from pydantic-tfl-api to pydantic_tfl_api in the installation command is intentional? If so, does this reflect a change in the package name that might require additional documentation or migration notes?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mnbf9rca mnbf9rca deleted the chore/update-documentation branch September 10, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant