Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove app_id from tfl api token as it's not needed any more #47

Closed
wants to merge 1 commit into from

Conversation

mnbf9rca
Copy link
Owner

@mnbf9rca mnbf9rca commented Jul 15, 2024

Summary by Sourcery

Removed the app_id parameter from the ApiToken class and updated the RestClient and associated tests to reflect this change.

  • Tests:
    • Updated tests to reflect the removal of the app_id parameter from the ApiToken class.

Copy link

sourcery-ai bot commented Jul 15, 2024

Reviewer's Guide by Sourcery

This pull request removes the 'app_id' parameter from the ApiToken class as it is no longer needed. The changes include updating the ApiToken class constructor, modifying the RestClient to exclude 'app_id' from its api_token dictionary, and adjusting the test cases to reflect these changes.

File-Level Changes

Files Changes
tests/test_basic_tests.py
pydantic_tfl_api/api_token.py
pydantic_tfl_api/rest_client.py
Removed the 'app_id' parameter from the ApiToken class and updated all relevant instantiations and assertions to reflect this change.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mnbf9rca mnbf9rca closed this Jul 15, 2024
@mnbf9rca mnbf9rca deleted the feat/remove-app_id-from-tfl-api-token branch July 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant