Pin v8 revision

Author: wenyuzhao

Dockerfile

@@ -16,10 +16,13 @@ RUN git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
 ENV PATH="/root/mmtk-v8-workspace/depot_tools:${PATH}"
 RUN gclient
 RUN fetch v8
-RUN gclient sync
 # Clone MMTk
 RUN git clone https://github.com/mmtk/mmtk-v8.git
 
+# Checkout a working V8 revision.
+# TODO: Use latest v8.
+RUN git -C v8 checkout 191b637f28c0e2c6ca5f2d6ac89377039a754337
+RUN gclient sync
 
 WORKDIR /root/mmtk-v8-workspace
 COPY ./args-debug.gn ./v8/out/x64.debug-mmtk/args.gn

README.md

@@ -4,7 +4,7 @@
 
 ### Build docker image
 
-*This will fetch the latest v8 and mmtk-v8 repo.*
+*This will fetch the ~~latest~~ `191b637f` v8 and the latest mmtk-v8 repo.*
 
 ```console
 $ docker image build -t mmtk-v8 .
@@ -24,3 +24,12 @@ $ docker container run mmtk-v8 # directly executes `gm x64.optdebug-mmtk.checkal
 $ docker container run -it mmtk-v8 bash
 root@70f9de71f77b:~/mmtk-v8-workspace# make check
 ```
+
+## Note!
+
+A specific v8 git revision (`191b637f`) is used at the moment due to the different third-party-heap API between
+v8 and mmtk-v8 -- V8 TPH api is changing rapidly at the moment.
+
+## TODO:
+
+- [ ] Use latest v8