Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pipewire playback on more modern systems #138

Merged
merged 6 commits into from
Feb 9, 2025
Merged

fix pipewire playback on more modern systems #138

merged 6 commits into from
Feb 9, 2025

Conversation

RiedleroD
Copy link
Contributor

this should fix any issues with modern pw. I don't have any older versions to test compat, so I hope this didn't break anything in older versions.

fixes #131

@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.11%. Comparing base (b6fed1f) to head (28398dc).
Report is 43 commits behind head on master.

Additional details and impacted files

see 16 files with indirect coverage changes

@mmitch
Copy link
Owner

mmitch commented Feb 8, 2025

Thanks a lot!
I'll check it against Pipewire 0.3.65 from Debian stable.
Our build pipeline had an even older Pipewire version that needed an #ifdef, but I think GitHub has just recently updated all build images to a newer Ubuntu version, so we can't check that version any more.

mmitch
mmitch reviewed Feb 9, 2025
View reviewed changes
plugout_pipewire.c
@@ -84,13 +84,11 @@ static long pipewire_open(enum plugout_endian *endian, long rate, long *buffer_b
&pipewire_data);

// connect the stream
// TODO: do we need the realtime flag?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not really know what I was doing when writing this code, but at least I was suspicious of this ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why the tutorials even use it 🤷🏻‍♀️

@mmitch
Copy link
Owner

mmitch commented Feb 9, 2025

This looks good, I don't see/hear any problems on Debian Bookworm!

I'd like to update the copyright year in the source file, but as I did nothing in this PR it feels weird that only my name is listed there.
Do you want to add yourself with name + email address as a second line like in plugout_devdsp.c?

If not, I'll just merge your PR and update the year later.

@RiedleroD
Copy link
Contributor Author

oh, sure! I'll add myself

@mmitch mmitch merged commit e015f8b into mmitch:master Feb 9, 2025
@RiedleroD RiedleroD deleted the fix-pipewire branch February 10, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitch mmitch mmitch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crackly audio on PipeWire output
2 participants
@RiedleroD @mmitch