Facts not fixed correctly

[matejzero]

Sorry for vague subject, can't think of a better one right now:)

I'm running VS Code puppet addon and some old modules are still using old facts which plugin tried to fix.

Example code:

class test::params {
  case $facts['os']['family'] {
    'RedHat': {
      case $facts['os']['release']['major'] {
        '6': {}
        default: {
          fail("${::osfamily} ${::operatingsystemmajrelease} based systems.")
        }
      }
    }
    default: {}
  }
}

This old facts get fixed to ${facts['facts['os']['family']'] which is obviously wrong.

VS Code says Puppet(legacy_facts) plugins is raising an error and the only plugin with that name I could find was this one. I hope this is the correct repo for filing this issue.

Let me know if you need more info and which.