Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ignite): allow to set param_groups to arbitrary values #1261

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

sebffischer
Copy link
Collaborator

This is needed for compatability with LR schedulers

Resolves Issue #1260

@sebffischer sebffischer requested a review from dfalbel January 28, 2025 14:31
Copy link
Member

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for tests and then merge

@sebffischer
Copy link
Collaborator Author

It's only the usual failures.

This is needed for compatability with LR schedulers

Resolves Issue mlverse#1260
@dfalbel dfalbel merged commit 1704ca0 into mlverse:main Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants