Made the ad-on support ROLE_DOCUMENT, so it works with the new Notepad and other such things. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and other such things.
|
Did you test it in other apps? It shouldn't trigger in browse mode or in Microsoft Word/WordPad - all of them have document as role. |
|
It always triggered in WordPad, as its ROLE_EDITABLETEXT. I don't have generic word to test it with, though. |
|
What about browse mode in browsers? I just checked that focused element
role appears to always be document. We don't want to trigger IndentNav
in browsers.
…On 8/25/2022 12:40 PM, Quin wrote:
It always triggered in WordPad, as its ROLE_EDITABLETEXT. I don't have
generic word to test it with, though.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJRDHES6JYTMGZU22UYSV3V27DZTANCNFSM57RHMQFA>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Ooh, excellent point. What else could we check for? Some property on the control? |
|
TBH not sure, it would probably require some tinkering. IIRC findOverlay
function is called pretty early so browse mode stuff maybe haven't been
initialized by then. I would suggest maybe check window class - if it is
unique for new notepad. Another solution - more fundamental - would be
to patch EditableText class and inject all keystrokes there instead of
trying to use NVDAObject API, but this would be a bigger effort.
…On 8/25/2022 1:25 PM, Quin wrote:
Ooh, excellent point. What else could we check for? Some property on
the control?
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJRDHCB4JWGDNXAJ3653N3V27JDXANCNFSM57RHMQFA>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Okay, we now check for the window class being RichEditD2DPT. All seems to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7