Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request an update to the add-on template #15

Closed
cary-rowen opened this issue May 6, 2024 · 5 comments
Closed

Request an update to the add-on template #15

cary-rowen opened this issue May 6, 2024 · 5 comments

Comments

@cary-rowen
Copy link
Collaborator

Hi @mltony

Currently this add-on is still using the old add-on template.

This caused an issue where the tables in the document were not being rendered correctly.

Of course we can have other ways of rendering the table, but I think using an add-on template is a more suitable option.
Using add-on templates you can also use github actions to publish add-on.

If you don't have time to do this right now, I'd be happy to help.

Btw, @nvdaes has helped register the add-on with the translation system. If you wish, you can grant me access to this repository and I will be willing to provide localization management.

Thanks
Cary

@nvdaes
Copy link

nvdaes commented May 6, 2024

Hello, translations seem to work as expected and they have been updated for this add-on.
Tomorrow I'll register wordNav.
Please let me know if I should grant access to the repo in nvdaaddons organization to someone in addition to @mltony.

@mltony
Copy link
Owner

mltony commented May 6, 2024

@nvdaes,
thank you for helping with translation system, please also grant full access to @cary-rowen.

@cary-rowen ,
I just granted you access to this repo. Updating addon template sounds like a good idea!

@cary-rowen
Copy link
Collaborator Author

@mltony
I will take the time to update the add-on template.

@nvdaes
Thanks for your efforts on this, and as Tony said, I'd like to have access to nvdaaddons/indent-nav as well.

I will also take the time to update sentence-nav. If possible, please also ask @nvdaes to help me check the access of nvdaaddons/sentence-nav.

Thanks a lot!

@mltony
Copy link
Owner

mltony commented May 7, 2024

@nvdaes, IJ confirm, could you also grant access to @cary-rowen for nvda-sentence-nav? Thanks!

@nvdaes
Copy link

nvdaes commented May 7, 2024

Hello, now @cary-rowen has access to sentenceNav and IndentNav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants