Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpoLogTrafoRegr() does not preserve coordinates of task #62

Open
pat-s opened this issue Nov 13, 2018 · 1 comment
Open

cpoLogTrafoRegr() does not preserve coordinates of task #62

pat-s opened this issue Nov 13, 2018 · 1 comment
Labels

Comments

@pat-s
Copy link
Member

pat-s commented Nov 13, 2018

Reprex:

library(mlr)
#> Loading required package: ParamHelpers
#> Warning: replacing previous import 'stats::filter' by 'dplyr::filter' when
#> loading 'mlr'
library(mlrCPO)

spatial.task$coordinates
#>              x       y
#> 31358 712882.5 9560002
#> 36710 715232.5 9559582
#> 21788 715392.5 9560172
#> 4965  715042.5 9559312
[...]

# just for demo purposes 
spatial.task$env$data$slides = as.numeric(spatial.task$env$data$slides)
spatial.task$task.desc$type = "regr"

task = spatial.task %>>% cpoLogTrafoRegr()

task$coordinates
#> NULL

Created on 2018-11-13 by the reprex package (v0.2.1)

@pat-s pat-s added the bug label Nov 13, 2018
@mb706
Copy link
Collaborator

mb706 commented Nov 13, 2018

Thanks!
Todo:

  • preserve coordinates slot
  • make coordinates mutable in FOCPO but not TOCPO (?)
  • how to handle this in ROCPO?
  • check consistency in assertTask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants