Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringi usage #138

Open
m-muecke opened this issue Jun 11, 2024 · 0 comments
Open

stringi usage #138

m-muecke opened this issue Jun 11, 2024 · 0 comments

Comments

@m-muecke
Copy link
Member

m-muecke commented Jun 11, 2024

Currently the only places where stringi is used is in R/helper.R, R/helper_xml.R and R/read_arff.R.
I assume the reason of using stringi is performance, since the following functions have base R equivalents:

  • stri_trim_both() : base::trimws()
  • stri_startswith_fixed(): base::startsWith()
  • stri_endswith_fixed(): base::endsWidth()
  • stri_sub():base:sub()

Suggestion would be to either replace the remaining base R string functions with stringi, since startsWith, etc. is still being used or remove stringi as a dependency for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant