Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting Boundaries in train_model.py --eval not just interior #108

Open
sadamov opened this issue Jan 28, 2025 · 0 comments
Open

Plotting Boundaries in train_model.py --eval not just interior #108

sadamov opened this issue Jan 28, 2025 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sadamov
Copy link
Collaborator

sadamov commented Jan 28, 2025

With milestone v0.4.0 we are releasing realistic boundaries. For that purpose the plotting functionalities need to be updated. Currently they only plot the interior domain, with a semi-transparent boundary around it. In the new approach the boundary and interior data comes from two separate datastores.

Some considerations:

  • Using domain_cropping in the config will keep only the points at the given distance from the convex hull of the referenced interior data. This set of points will in general not lay on a regular grid.
  • There is no boundary mask in neural-lam right now. All points in the boundary datastore are considered boundary input points.
  • As plots anyhow are in the crs of the interior, boundary points would still not lay on a regular grid (if they were originally in e.g. a regular lat-lon grid).

I started working on this but got lost in the x,y,lat,lon,projections,coordinates. When are they 1D, when are they 2D, stacked unstacked. Anyways :D here is my working branch: https://github.com/sadamov/neural-lam/tree/plot_boundaries But unfortunately I don't have the bandwidth right now to continue working on it. A typical example plot looks like this:

Image

@sadamov sadamov added enhancement New feature or request help wanted Extra attention is needed labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant