Register h5 #5
Register h5 #5
Conversation
There was a problem hiding this comment.
This all looks great.
Just to record my understanding of this: Since user-defined adapters take precedence over the default ones, any file with file-extension registered to mimetype application/x-hdf5 ingested with this script will get the additional spec, but since we are still returning a regular HDF5Adapter, we have no need to implement any of the reading functionality.
Yes, and this would be very problematic in some cases, but since we control when this is ever called (it's only in our custom rabbit/activeMQ listener at Diamond listening for reconstructions), we can get away with it. If this were a more generic place, we would need to investigate the h5 file in this code to make sure it actually corresponds to our spec.
Right. Adding these specs allows us to some day build out the full on adapter if we decide we need it... Oh, this is a diamond tomo? Well, when we serve This PR closes #5 |
This PR adds a partial adapter to add a spec.
To put it another way, this will get called for every h5 file registered, and by the
process_filefunction, which give it a chance to add the diamond tomography spec that will get used downstream.