Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate all strings #4

Open
mleko opened this issue Oct 17, 2019 · 12 comments
Open

Translate all strings #4

mleko opened this issue Oct 17, 2019 · 12 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@mleko
Copy link
Owner

mleko commented Oct 17, 2019

Some strings are hardcoded in Polish, make them translatable

@mleko mleko added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 17, 2019
mrosati84 added a commit to mrosati84/lets-play that referenced this issue Oct 22, 2019
mleko added a commit that referenced this issue Oct 22, 2019
fix one untranslatable string #4 #hacktoberfest
@abbasCoder51
Copy link
Contributor

@mleko Can I contribute to this?

@mleko
Copy link
Owner Author

mleko commented Oct 24, 2019

@abbasCoder51 Sure

@abbasCoder51
Copy link
Contributor

@mleko trying to build project on local machine, navigated to frontend folder and ran the following commands:-

npm install
npm start

Getting a bunch of errors, is there something that I'm missing?

@mleko
Copy link
Owner Author

mleko commented Oct 25, 2019

Yes. I've checked, there is error in README. In this project yarn is used instead of npm
try running

yarn install
yarn start

@abbasCoder51
Copy link
Contributor

@mleko any instructions on how to build and run the backend code? I want to check if the translations are working as intended.

@mleko
Copy link
Owner Author

mleko commented Oct 28, 2019

I updated README in commit 4b2b18f
I hope it will make easier to run app

@mleko
Copy link
Owner Author

mleko commented Nov 9, 2019

Hi @abbasCoder51 are you still interested in working on this issue?

@abbasCoder51
Copy link
Contributor

@mleko yes I am, I'll do a pull request soon

@abbasCoder51
Copy link
Contributor

lets-play-screenshot

I've ran both the frontend (http://localhost:8080/) and backend (http://localhost:8000/). When I try to login seem to get this error. Have I missed out a step?

@mleko
Copy link
Owner Author

mleko commented Nov 23, 2019

Can you check var/log/dev.log for errors?

@abbasCoder51
Copy link
Contributor

[2019-11-24 00:17:21] php.CRITICAL: Uncaught Exception: An error occurred while trying to encode the JWT token. Please verify your configuration (private key/passphrase) {"exception":"[object] (Lexik\Bundle\JWTAuthenticationBundle\Exception\JWTEncodeFailureException(code: 0): An error occurred while trying to encode the JWT token. Please verify your configuration (private key/passphrase) at C:\Work Projects\lets-play\backend\vendor\lexik\jwt-authentication-bundle\Encoder\LcobucciJWTEncoder.php:37, InvalidArgumentException(code: 0): It was not possible to parse your key, reason: error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt at C:\Work Projects\lets-play\backend\vendor\lcobucci\jwt\src\Signer\OpenSSL.php:90)
[stacktrace]

I think this is the issue, any suggestions?

@mleko
Copy link
Owner Author

mleko commented Nov 24, 2019

It looks related to JWT keys. Info how to configure/generate keys is available https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/Resources/doc/index.md#generate-the-ssh-keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants