New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert from regex to glob using library #798

Open

ccl-core opened this issue Jan 24, 2025 · 0 comments

Labels

Contributor

ccl-core commented Jan 24, 2025

Currently, we convert a regular expression to a glob pattern manually:

croissant/python/mlcroissant/mlcroissant/_src/core/regex.py

Line 52 in f2d0cfd

def _regex_to_glob_for_str(regex: str) -> Iterable[str]:

Using a library instead of relying on manual heuristics might be more robust.

ccl-core added the enhancement label

ccl-core mentioned this issue

Handle dash in the regex2glob function #795

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment