You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the backup URLs are handled using the logical OR (||) operator, as shown in this line.
Consider a scenario where we have a main URL and a backup URL for downloading a model. If a user terminates the program using 'Ctrl+C' while downloading from the main URL, the current implementation causes the download to fail and immediately attempts to download from the backup URL instead of exiting the whole program. This is not the desired behavior.
Potential fix:
Keep the existing implementation as it is and implement an safe exit mechanism through trapping the interrupts. This was earlier implemented here.
The text was updated successfully, but these errors were encountered:
arjunsuresh
changed the title
Suggestions needed - better handlinng of backup URLs
Suggestions needed - better handling of backup URLs
Sep 18, 2024
Hi @anandhu-eng let's keep this issue open and we can decide based on the user feedbacks. Currently ctrl+c can be useful to switch to a backup url in case the main url download is slow.
Currently, the backup URLs are handled using the logical OR (||) operator, as shown in this line.
Consider a scenario where we have a main URL and a backup URL for downloading a model. If a user terminates the program using 'Ctrl+C' while downloading from the main URL, the current implementation causes the download to fail and immediately attempts to download from the backup URL instead of exiting the whole program. This is not the desired behavior.
Potential fix:
Keep the existing implementation as it is and implement an safe exit mechanism through trapping the interrupts. This was earlier implemented here.
The text was updated successfully, but these errors were encountered: