Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions needed - better handling of backup URLs #235

Open
anandhu-eng opened this issue Sep 18, 2024 · 2 comments
Open

Suggestions needed - better handling of backup URLs #235

anandhu-eng opened this issue Sep 18, 2024 · 2 comments

Comments

@anandhu-eng
Copy link
Contributor

anandhu-eng commented Sep 18, 2024

Currently, the backup URLs are handled using the logical OR (||) operator, as shown in this line.

Consider a scenario where we have a main URL and a backup URL for downloading a model. If a user terminates the program using 'Ctrl+C' while downloading from the main URL, the current implementation causes the download to fail and immediately attempts to download from the backup URL instead of exiting the whole program. This is not the desired behavior.

Potential fix:
Keep the existing implementation as it is and implement an safe exit mechanism through trapping the interrupts. This was earlier implemented here.

@arjunsuresh arjunsuresh changed the title Suggestions needed - better handlinng of backup URLs Suggestions needed - better handling of backup URLs Sep 18, 2024
@arjunsuresh
Copy link
Contributor

Hi @anandhu-eng let's keep this issue open and we can decide based on the user feedbacks. Currently ctrl+c can be useful to switch to a backup url in case the main url download is slow.

@anandhu-eng
Copy link
Contributor Author

Sure @arjunsuresh, that sounds like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants