Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert main scripts to console entry points #701

Closed
wants to merge 1 commit into from
Closed

Conversation

sunny1401
Copy link
Collaborator

Fixes #610

Proposed Changes

  • Moved all interactive to within cli as in the comments here
  • Updated the setup file
  • Removed the prior scripts
  • Updated to major version change to avoid breaking anything

Checklist

@github-actions
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sunny1401
Copy link
Collaborator Author

sunny1401 commented Jul 30, 2023

@sarthakpati - Hi, I have an initial PR - I need to update docs etc and make sure checks pass- but could you have a look and see if this is on the right track please

@sunny1401 sunny1401 marked this pull request as draft July 30, 2023 21:01
@sunny1401 sunny1401 changed the title mlcommons/issue-610-convert-main-scripts-to-console-entry-points Convert main scripts to console entry points Jul 30, 2023
@sarthakpati
Copy link
Collaborator

@sarthakpati - Hi, I have an initial PR - I need to update docs etc and make sure checks pass- but could you have a look and see if this is on the right track please

Broad brush strokes looking good! I'll wait for the tests to pass before doing a major review.

@sunny1401
Copy link
Collaborator Author

@sarthakpati - Hi sorry this is going slow.. I wanted to ask one additional thing. How does the versioning work - most of the test fail cause of

{'maximum': '0.0.17', 'minimum': '0.0.14'}

However, because this change is changing the way functionality is being accessed - I added it as a major version change instead of minor version change. The above tests only allow bug version updates; but I don't think this is a bug. Could you clarify?

@sarthakpati
Copy link
Collaborator

Hey @sunny1401, can you update your branch? I think the tests that are getting reported are older.

Also, the version check [ref] should take the full version into account (it is only considering the patch version ATM because the major and minor versions are 0).

@github-actions
Copy link
Contributor

Stale pull request message

@sarthakpati
Copy link
Collaborator

Hi @sunny1401, are you still working on this?

@sunny1401
Copy link
Collaborator Author

sunny1401 commented Nov 9, 2023 via email

@sarthakpati
Copy link
Collaborator

Hi sorry- I added some test cases but I haven’t finished and I am not actively on it anymore.

Cool, thanks for the update!

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Stale pull request message

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Stale pull request message

@VukW
Copy link
Contributor

VukW commented Mar 17, 2024

No way, machine, it's still active

@sarthakpati
Copy link
Collaborator

This has been superseded by #818

@sarthakpati sarthakpati deleted the issue-610 branch April 26, 2024 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert main scripts to console entry points
3 participants