-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert main scripts to console entry points #701
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@sarthakpati - Hi, I have an initial PR - I need to update docs etc and make sure checks pass- but could you have a look and see if this is on the right track please |
Broad brush strokes looking good! I'll wait for the tests to pass before doing a major review. |
@sarthakpati - Hi sorry this is going slow.. I wanted to ask one additional thing. How does the versioning work - most of the test fail cause of {'maximum': '0.0.17', 'minimum': '0.0.14'} However, because this change is changing the way functionality is being accessed - I added it as a major version change instead of minor version change. The above tests only allow bug version updates; but I don't think this is a bug. Could you clarify? |
Hey @sunny1401, can you update your branch? I think the tests that are getting reported are older. Also, the version check [ref] should take the full version into account (it is only considering the patch version ATM because the major and minor versions are |
Stale pull request message |
Hi @sunny1401, are you still working on this? |
Hi sorry- I added some test cases but I haven’t finished and I am not
actively on it anymore.
…On Thu, 9 Nov 2023 at 14:07, Sarthak Pati ***@***.***> wrote:
Hi @sunny1401 <https://github.com/sunny1401>, are you still working on
this?
—
Reply to this email directly, view it on GitHub
<#701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPIYKREUP7XCYO5AE6F6JLYDTPT7AVCNFSM6AAAAAA25NNEVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTHEYDCMBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Cool, thanks for the update! |
Stale pull request message |
Stale pull request message |
No way, machine, it's still active |
This has been superseded by #818 |
Fixes #610
Proposed Changes
Checklist
CONTRIBUTING
guide.