Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webLLMGlobal reference #585

Open
lestan opened this issue Sep 29, 2024 · 2 comments
Open

webLLMGlobal reference #585

lestan opened this issue Sep 29, 2024 · 2 comments

Comments

@lestan
Copy link

lestan commented Sep 29, 2024

In the get started example, there's a reference to webLLMGlobal in the get_started.html file. I also see it in the streaming example (streaming.html).

What does this code block / variable do?

<script>
    webLLMGlobal = {};
</script>

Trying to determine if it's a global reference to the engine and if it's set by webllm when the engine is created or if it's something else. I don't see it being referenced in the code within those examples so wasn't sure of its purpose.

Appreciate any insight and guidance. Thanks!

Reference: https://github.com/mlc-ai/web-llm/blob/main/examples/get-started/src/get_started.html

@flatsiedatsie
Copy link

I'm also curious about this. I've kept it in my code, but am unsure of it's use.

@tqchen
Copy link
Contributor

tqchen commented Oct 10, 2024

I belive this may be a legacy code that is no longer needed, cc @CharlieFRuan @Neet-Nestor . let us cross check and confirm, if it is not needed, we should remove from our example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants