Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort reload() if receiving another reload() call #484

Open
Neet-Nestor opened this issue Jun 19, 2024 · 0 comments
Open

Abort reload() if receiving another reload() call #484

Neet-Nestor opened this issue Jun 19, 2024 · 0 comments
Assignees

Comments

@Neet-Nestor
Copy link
Contributor

Currently, if we call engine.reload() while a loading is already in progress, the ongoing one will not be aborted but instead two reload will run concurrently and the callback will be called for all these progresses. This is not the preferred behavior.

Instead, it's better to cancel or abort the previous reload before initializing the new model reloading. This behavior is intuitive and easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant