Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative syntax for wallet initialisation #104

Open
szg251 opened this issue Jul 29, 2022 · 2 comments
Open

Alternative syntax for wallet initialisation #104

szg251 opened this issue Jul 29, 2022 · 2 comments

Comments

@szg251
Copy link
Collaborator

szg251 commented Jul 29, 2022

we already have a lot of arguments packed to the wallet generation (utxos, value assertion, etc.), and we might implement even more flexibility in the future (predefined signing key, staking key, partial value assertions, etc.), it would make sense to refactor our wallet initialisation syntax.
TBD: do we want to maintain the original syntax for compatibility and to be used by simple contracts?
@klntsky
Copy link
Contributor

klntsky commented Aug 5, 2022

We are struggling with finding a good interface also. This PR adds staking keys.

I think using tuples instead of pattern-matching on lists is definitely an advantage (type safety)

@IAmPara0x IAmPara0x self-assigned this Aug 9, 2022
@IAmPara0x IAmPara0x mentioned this issue Aug 10, 2022
Closed
9 tasks
@mikekeke
Copy link
Collaborator

mikekeke commented Aug 29, 2022 •
edited
Loading

Related issues: #121, #103

@zmrocze zmrocze mentioned this issue Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikekeke @szg251 @klntsky @IAmPara0x