Skip to content

Commit dcddfa0

Browse files
bladyjokercstml
andauthored
Apply suggestions from code review
Co-authored-by: Vlad <[email protected]>
1 parent 669e3f3 commit dcddfa0

File tree

1 file changed

+15
-5
lines changed
  • lambda-buffers-compiler/test/Test/LambdaBuffers/Compiler

1 file changed

+15
-5
lines changed

lambda-buffers-compiler/test/Test/LambdaBuffers/Compiler/WellFormed.hs

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,19 @@ import Proto.Compiler_Fields (argKind, argName, column, constrName, constructors
2525
import Proto.Compiler_Fields qualified as P
2626
import Test.LambdaBuffers.Compiler.Utils (distribute, indexBy)
2727

28+
29+
-- | Default constant range
30+
defRange = HR.constant lowerBound upperBound
31+
-- or defSize
32+
2833
-- | Upper bound on various generators
29-
limit :: Int
30-
limit = 5
34+
upperBound :: Int
35+
upperBound = 5
36+
37+
-- | Lower bound on various generators
38+
lowerBound :: Int
39+
lowerBound = 1
40+
3141

3242
-- | Names
3343
genAlphaNum :: H.Gen Char
@@ -36,7 +46,7 @@ genAlphaNum = H.alphaNum
3646
genUpperCamelCase :: H.Gen Text
3747
genUpperCamelCase = do
3848
h <- H.upper
39-
t <- H.list (HR.constant 1 limit) genAlphaNum
49+
t <- H.list defRange genAlphaNum
4050
return $ Text.pack $ h : t
4151

4252
genModuleNamePart :: H.Gen ModuleNamePart
@@ -46,7 +56,7 @@ genModuleNamePart = do
4656

4757
genModuleName :: H.Gen ModuleName
4858
genModuleName = do
49-
ps <- H.list (HR.constant 1 limit) genModuleNamePart
59+
ps <- H.list defRange genModuleNamePart
5060
return $ defMessage & parts .~ ps
5161

5262
genTyName :: H.Gen TyName
@@ -67,7 +77,7 @@ genConstrName = do
6777
genVarName :: H.Gen VarName
6878
genVarName = do
6979
h <- H.lower
70-
t <- H.list (HR.constant 1 4) H.lower
80+
t <- H.list defRange H.lower
7181
return $ defMessage & name .~ Text.pack (h : t)
7282

7383
starKind :: Kind

0 commit comments

Comments
 (0)