Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] container or composition of services for e2e processing #213

Closed
1 of 2 tasks
jastier opened this issue Jun 2, 2023 · 7 comments
Closed
1 of 2 tasks

[docker] container or composition of services for e2e processing #213

jastier opened this issue Jun 2, 2023 · 7 comments
Assignees

Comments

@jastier
Copy link
Contributor

jastier commented Jun 2, 2023

Implement interprocess communication within Docker

The SKEMA architecture (.pdf and .graffle files) are on a Google drive here

  • Create branch 'docker_integration' (done)
  • Create network service 'skema_net'. docker-compose.yml will create this network if needed (done)
  • Add this service to existing compose files (done)
  • Test REST API comms end to end (skema-rs, skema-py servers are active on skema_net)

When building images to push to DockerHub, use the following naming convention from Issue ml4ai/skema#221:

Tasks

  1. Integration
    myedibleenso
  2. 2 of 2
    Integration documentation
    jastier
@jastier jastier self-assigned this Jun 2, 2023
@myedibleenso
Copy link
Collaborator

Let's use this issue to document our conversation around service orchestration.

@myedibleenso myedibleenso changed the title Docker integration [docker] container or composition of services for e2e processing Jun 6, 2023
@enoriega
Copy link
Member

enoriega commented Jun 7, 2023

Hi guys. The TA-1 orchestration repository lives at https://github.com/ml4ai/ASKEM-TA1-DockerVM/

This is where Chunwei and I have started work to consolidate our TR apis.

Should we use that repository to manage the orchestration of the rest of the Skema images too?

@myedibleenso myedibleenso added this to the [DARPA] Milestone 9 milestone Jun 9, 2023
@myedibleenso
Copy link
Collaborator

Are all of our compose files for service orchestration going to live in https://github.com/ml4ai/ASKEM-TA1-DockerVM/ for the time being? Do we want to do the same with example notebooks?

@enoriega
Copy link
Member

enoriega commented Jun 9, 2023

It is my understanding that yes, that is the current agreement. https://mlbayes.slack.com/archives/C05AD8860S2/p1686162741083959

The notebooks should live on the same place as the compose file, as they're the documentation on how to use them for TA-4

@enoriega
Copy link
Member

One additional repo has a docker image part of this integration project. The image is currently hand built and pushed into my personal hub account. @myedibleenso can you help replicate the config to do it automatically to our organization's hub?

ml4ai/ASKEM-TA1-DataModel#15

@jastier
Copy link
Contributor Author

jastier commented Jul 18, 2023

I believe this was completed for the June 28 Uncharted demo and was never closed out.

@myedibleenso
Copy link
Collaborator

Completed prior to start of hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants