-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoDJ toggle not working with Denon DJ MC7000 in 2.3.3 #10754
Comments
Commented by: ronso0 The AutoDJ toggle in the GUI doesn't work? |
Commented by: thomi Hello Yes, AutoDJ toggle in the GUI not working if Denon DJ MC7000 is connected. I also have a Hercules DJ Console MK2 and with this controller, AutoDJ does work like usual. Attached are developer logs for both controller. Hope this helps to identify the issue. Thanks & regards |
Commented by: thomi Currently i downgraded to mixxx 2.3.2-1~focal and AutoDJ toggle is back and running with connected Denon DJ MC7000. |
Commented by: ronso0 Looking at the MC7000 mapping files, I have no clue how there could be a connection between that and AutoDJ. Just to double check:
|
Commented by: thomi Hey ronso0 with either of those two controllers you have
Yes, if working with 2.3.3, then i can do manual DJing, load and play tracks like usual.
Yes, tested with tracks and with the option that AutoDJ adds automatic tracks, if empty.. As above wrote, with 2.3.2 AutoDJ works like a charm,e ven with MC7000 and with Hercules MK2. |
Commented by: toszlanyi Interesting, as I never integrated any AutoDJ functions in the mapping... Cannot see any issue related to the last changes at #4755 as well but maybe worth a try to copy the 2.3.2 mapping to the personal folder and test it while using Mixxx v2.3.3 just to make sure. |
Commented by: ronso0 Yeah, worth testing the old mapping. Though I suspect this is a regression caused by the recent AutoDJ fixes. Maybe related to Vol fader or crossfader position? Idk.. @thomi Can you please try to replicate the working state (with Herc Mk2) with the MC7000? @daschuer may know |
Commented by: thomi Okey, what i did...
Result > nothing happens
Downgraded to 2.3.2 and did the same as above
Tested the same with MK2 in 2.3.2 and 2.3.3 regards |
Commented by: thomi Hello Any news in this? Many thanks |
Commented by: daschuer There where significant changes between 2.3.2 and 2.3.3 to the Auto DJ code. You may try out the PR builds to find out which one introduces the regression: #4693 #4714 #4698 #4768 The builds are on the bottom of the second link. You to be logged in on GitHub to see the links. |
Commented by: thomi Good morning
I tried to download the DEB builds, but could only download it for: All others are expired. The build from your links i can download is mixxx-2.4-alpha-1164-g0a9b879186.deb after 2.3.3 will 2.4 come or is there a plane for eg. 2.3.4? thomi |
Commented by: daschuer I think we will release a last 2.3.x version somewhere close to a 2.4.0 version. Do you have any new test results, with the available builds? Maybe I find time to create you a test version with more log output to drill down the issue. Are you able to build Mixxx from source? |
Commented by: thomi hey
using main branch or 2.3 to build and test it? |
Commented by: daschuer Yes, later I can point you to commits that can be tested. |
Commented by: thomi hey . checked out main branch error see attachment.. i'm on zorin os 16.1 which is based on ubuntu... any hint? |
Commented by: thomi got it... needed to checkout the mentioned commit... let me build for those 4 commits and check on my system... |
Commented by: daschuer The build error happens due to dropping focal support from our main branch.
I just realize realized that Zorin OS has not jet updated to Ubuntu 22.04 LTS base. |
Commented by: thomi hey hey sorry, can't build it correctly for my dj'ing system and also don't find time to analyse, debug it deeply... hm...
|
Commented by: ronso0 I managed to build main on 20.04 with gcc10 |
okey.. thanks @ronso0, will continue here ;) let's re-post my last comment, cause it's not posted here... okay.. found time to build with gcc9 and installed it.. controller and all shortly tested features work.. built the deb file on focal based on: Mixxx 2.4.0-alpha-pre Now i lost my workin 2.3.2 :(.... and have to build it manually.. or is there any download for this file: regards |
Unfortunately all our resources for that version have expired. You click the Auto DJ toggle button and you have Tracks in the queue, right? Is there a difference if the controller is connected or not? |
yes sure
yes, if controller not connected or i connect my hercules mk2 controller, AutoDj does work! |
@thomich If you managed to built 2.3 and main with cmake you can easily checkout the commits @daschuer pointed to (#10754 (comment)) and test with which commit the behaviour changes. If that's not feasible for you we can create a branch with debug output in |
What about your crossfader assign switches? |
Yes, exactly that. Please test again with xfader switches at default position (deck 1/3: left, deck 2/4: right). |
good morning... think i found the issue, problem... First, the switches do work in all tested versions if i change them on the MC7000. With 2.3.2 and 2.3.2-15-g4d1f1119d1 AutoDJ works even if crossfader switches are centered or for 1 left and 2 right. With 2.3.2-25-g889108a98b AutoDJ can only be started if the crossfader switches are NOT centered: 1 left, 2 right or vise versa. The AutoDJ toggle an all older versions including 2.3.2-15-g4d1f1119d1 do work even if crossfader switches are centered or left/right. But starting with 2.3.2-25-g889108a98b AutoDJ only works if crossfader switches are left or even right, based on the channel/deck. Hope this helps to identify and fix the problem as it was in previous versions. regards |
How does AutoDJ work for you with centered crossfader setting? |
hey @daschuer In earlier versions, it just worked with centered position...can't that be adapted in new versions? |
If there is a valid use case for this, sure. |
Use case: If a DJ by default is working w/o crossfader, there is no need to change the crossfader switch from center to left/right. In my case i mostly work w/o crossfader and do the mixes direct with the channel faders. thx |
..then s/he is working with Volume faders and/or EQs to blend tracks manually. For the time being, AutoDJ works with crossfader only. With both decks in through mode (xfader switch centered) there will be no crossfader blending. So I guess you either use it with no transition at all, or you interfere with the EQs / Vol fader? What are the arguments for considering the "non-auto AutoDJ" use case? For now, I agree with @daschuer to show a popup explaining that AutoDJ requires the crossfader switches set left & right, and also add that info to the manual. That would at least avoid confusion. |
okey.. no problem for me, so following would be best solution then:
many thanks... |
again: please explain how you use AutoDJ so we can understand your use case. |
okey.. ;) If i need a break, i add some tracks into autodj queue or even set some crates and start autodj to make my break... With 2.3.2 it was easy, just add some tracks, enable creats and start autodj, nothing else (expect fader volume of deck 1&2 to 100%). thomi |
how do you configure transitions? |
Yes, I meant the AutoDJ controls in the library. |
If i understand it correct, it does auto fade automatically.. means left channel volume fades out trough the crossfader and right channel fades in, and the duration is 6 seconds, based on that setting. |
That's what it would do if the crossfader switches where set to left / right. If both are centered, there's no fading. |
but again, sorry for that, but that worked in earlier version's, it fades down/up even if crossfader switches are centered. so what now? make a message box, if crossfader switches not left/right? |
can not confirm.
|
good morning ;) hope this will explain and show how it works with 2.3.2 and MC7000 controller with built in mapping. Mixxx 2.3.2 - AutoDJ Constant Power Fading Mixxx 2.3.2 - AutoDJ Soft Fading And a video of the MC7000 while AutoDJ on 2.3.2 is working: If you think that is a bug in 2.3.2 it is solved with cf switches position left/right.. but then we need a message box, if starting AutoDJ and cf switches are centered. |
See how the VU jumps up at ~0:22 when deck2 kicks in? To clarify, please try to simply record this as described, not with AutoDJ (also the left deck's outro is faded out already).
Thank you |
hope i understand your correct... with 2.3.2 i needed to set cf switches to left/right to get cf manually working: Mixxx 2.3.2 - Soft Fading - cf switch left right |
this should be the case, and that's the point I'm trying to make: so, with centered switches there won't be crossfade effect with AutoDJ either, unless your tracks are fading in / out. |
Closing this now. Feel free to reopen if there is a valid use case. |
my friend.. all fine for me but now, do you add a message box if clicking on AutoDJ toggle and cf switches are centered? |
Reported by: thomi
Date: 2022-06-23T15:42:06Z
Status: New
Importance: Undecided
Launchpad Issue: lp1979670
Attachments: [Developer Logs for MC7000 and MK2](https://bugs.launchpad.net/bugs/1979670/+attachment/5599452/+files/Developer Logs for MC7000 and MK2), mixxx_build_error.png
Kubuntu 20.04
Intel i7, 8x4Core
Mixxx 2.3.3
Denon DJ MC7000, mapping integrated by OsZ
Have upgraded to latest 2.3.3, thanks to the Mixxx Team.
If MC7000 is connected and configured, i can't start AutoDJ.
Click on AutoDJ button, nothing happens.
If MC7000 not connected, AutoDJ working like normal.
I also dont find any error if start mixxx from console.
If any more info needed, let me know.
Regards
thomi
The text was updated successfully, but these errors were encountered: