Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faster serialization handler picking #50

Open
mivanit opened this issue Feb 23, 2024 · 0 comments
Open

faster serialization handler picking #50

mivanit opened this issue Feb 23, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mivanit
Copy link
Owner

mivanit commented Feb 23, 2024

Details

  • JsonSerializer().json_serialize() picks a handler by checking every single handler via a for loop
  • this scales poorly if we have a lot of handlers
  • it would be faster to build some kind of dict of handlers to first check the most likely handlers
  • this breaks handler ordering, unfortunately -- not sure how to deal with this
@mivanit mivanit added enhancement New feature or request good first issue Good for newcomers labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mivanit