From f501409843102385b4385c5fa16c2050235cc43b Mon Sep 17 00:00:00 2001 From: Andrew Garrett Date: Thu, 2 Apr 2015 10:59:57 +0200 Subject: [PATCH] Fix URL handling: Previously we unconditionally appended ?, switched two locations to use add_query --- flask_oauth.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/flask_oauth.py b/flask_oauth.py index b21105a..c1a655c 100644 --- a/flask_oauth.py +++ b/flask_oauth.py @@ -329,8 +329,10 @@ def authorize(self, callback=None): """ if self.request_token_url: token = self.generate_request_token(callback)[0] - url = '%s?oauth_token=%s' % (self.expand_url(self.authorize_url), - url_quote(token)) + url = add_query( + self.expand_url(self.authorize_url), + {'oauth_token': token} + ) else: assert callback is not None, 'Callback is required OAuth2' # This is for things like facebook's oauth. Since we need the @@ -370,9 +372,9 @@ def handle_oauth1_response(self): function. """ client = self.make_client() - resp, content = client.request('%s?oauth_verifier=%s' % ( + resp, content = client.request(add_query( self.expand_url(self.access_token_url), - request.args['oauth_verifier'] + {'oauth_verifier': request.args['oauth_verifier']} ), self.access_token_method) data = parse_response(resp, content) if not self.status_okay(resp):