Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot dependencies updates #73

Merged
merged 3 commits into from
Dec 8, 2023
Merged

dependabot dependencies updates #73

merged 3 commits into from
Dec 8, 2023

Conversation

georgedias
Copy link
Contributor

@georgedias georgedias commented Sep 19, 2023

Fix previous dependabot merges that were not validated.

  • Fix moving to flat to version 6.0 - it is breaking when using the unflatten method.

@aaronlippold
Copy link
Member

@georgedias Why are we pinning flat to v5 ... aka no ^ at the beginning and downgrading to v5 from v6? It seems like this PR is needed prior to #40 being merged and #40 is the one with the high fiding.

Can we take a few min to look at this and see if we can close these out.

@georgedias
Copy link
Contributor Author

@em-c-rod and I found that moving to flat 6.0 fails when using the unflatten method. Have not had the change to look into the issue.

Copy link
Contributor

@em-c-rod em-c-rod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of merging this to start with working tests before merging in more dependabot updates.

@em-c-rod em-c-rod merged commit 15a3b8a into main Dec 8, 2023
2 checks passed
@em-c-rod em-c-rod deleted the cleaning_dependencies branch December 8, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants