Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store version of plugin.rs::PluginCacheEntry as semver Version struct #819

Open
j-lanson opened this issue Jan 23, 2025 · 0 comments
Open

Store version of plugin.rs::PluginCacheEntry as semver Version struct #819

j-lanson opened this issue Jan 23, 2025 · 0 comments
Assignees
@ninaagrawal
Labels
product: hc Relates to the core "hc" binary type: chore Clean up or management task. type: refactor Changes to code structure that do not impact functionality

Comments

@j-lanson
Copy link
Collaborator

Currently stored as string and parsed during every comparison using compare_versions(), which is quite inefficient.
@j-lanson j-lanson added product: hc Relates to the core "hc" binary type: chore Clean up or management task. type: refactor Changes to code structure that do not impact functionality labels Jan 23, 2025
@j-lanson j-lanson mentioned this issue Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninaagrawal ninaagrawal

Labels
product: hc Relates to the core "hc" binary type: chore Clean up or management task. type: refactor Changes to code structure that do not impact functionality
Projects
Hipcheck Dev Roadmap
Status: Todo
Hipcheck Product Roadmap
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j-lanson @ninaagrawal