Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper logging for plugins #381

Open
j-lanson opened this issue Sep 11, 2024 · 1 comment
Open

Proper logging for plugins #381

j-lanson opened this issue Sep 11, 2024 · 1 comment
Assignees
Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Milestone

Comments

@j-lanson
Copy link
Collaborator

j-lanson commented Sep 11, 2024

Currently in plugin/manager.rs::start_plugin(), we directly pipe plugin stdout/stderr to Hipcheck stdout/stderr. We should have a more structured logging that integrates with the existing logging in Hipcheck, and also specifies which plugin the message came from.

@j-lanson j-lanson changed the title DRAFT: Proper logging for plugins Proper logging for plugins Sep 11, 2024
@j-lanson j-lanson added the type: enhancement New feature or request label Sep 11, 2024
@j-lanson j-lanson added this to the 3.7.0 milestone Sep 11, 2024
@alilleybrinker alilleybrinker added the product: hc Relates to the core "hc" binary label Sep 11, 2024
@j-lanson
Copy link
Collaborator Author

Notes from discussion with Andrew:

  • add a plugin-specific prefix to the output in stdout/stderr
  • integrate with our logging levels so can be filtered out

@j-lanson j-lanson modified the milestones: 3.7.0, 3.8.0 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Projects
Status: Todo
Status: No status
Development

No branches or pull requests

3 participants