fix: Broken release build for Hipcheck.

Turns out Cargo doesn't like when materials required to build a crate are
outside of the crate manifest directory. In this case, I'm talking about
the protobuf definition used for the Hipcheck plugin gRPC service.

There's a Cargo issue open about it, but the gist of it is that they
don't really want people doing what we were trying to do, having materials
in an outer directory.

There may be better solutions, but moving the files is the fastest one
for now.

Here's the issue: rust-lang/cargo#3946

Signed-off-by: Andrew Lilley Brinker <[email protected]>

Author: alilleybrinker

hipcheck/Cargo.toml

@@ -11,7 +11,7 @@ edition = "2021"
 license = "Apache-2.0"
 homepage = "https://mitre.github.io/hipcheck"
 repository = "https://github.com/mitre/hipcheck"
-include = ["src/**/*", "../LICENSE", "../README.md", "build.rs"]
+include = ["src/**", "../LICENSE", "../README.md", "build.rs", "proto/**"]
 
 # Rename the binary from the default "hipcheck" (based on the package name)
 # to "hc".
@@ -141,6 +141,7 @@ zstd = "0.13.2"
 [build-dependencies]
 
 anyhow = "1.0.86"
+pathbuf = "1.0.0"
 tonic-build = "0.12.1"
 which = { version = "6.0.3", default-features = false }
 

hipcheck/build.rs

@@ -1,6 +1,12 @@
 // SPDX-License-Identifier: Apache-2.0
 
-fn main() -> anyhow::Result<()> {
-	tonic_build::compile_protos("../proto/hipcheck/v1/hipcheck.proto")?;
+use anyhow::Result;
+use pathbuf::pathbuf;
+use tonic_build::compile_protos;
+
+fn main() -> Result<()> {
+	let root = env!("CARGO_MANIFEST_DIR");
+	let path = pathbuf![root, "proto", "hipcheck", "v1", "hipcheck.proto"];
+	compile_protos(path)?;
 	Ok(())
 }

proto/hipcheck/v1/hipcheck.proto renamed to hipcheck/proto/hipcheck/v1/hipcheck.proto

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 fn main() -> anyhow::Result<()> {
-	tonic_build::compile_protos("../../proto/hipcheck/v1/hipcheck.proto")?;
+	tonic_build::compile_protos("../../hipcheck/proto/hipcheck/v1/hipcheck.proto")?;
 	Ok(())
 }

plugins/dummy_rand_data/build.rs

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 fn main() -> anyhow::Result<()> {
-	tonic_build::compile_protos("../../proto/hipcheck/v1/hipcheck.proto")?;
+	tonic_build::compile_protos("../../hipcheck/proto/hipcheck/v1/hipcheck.proto")?;
 	Ok(())
 }