Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should look into a replacement lib to handle zip files #4874

Open
charleshu-8 opened this issue Aug 25, 2023 · 2 comments · May be fixed by #6018
Open

Should look into a replacement lib to handle zip files #4874

charleshu-8 opened this issue Aug 25, 2023 · 2 comments · May be fixed by #6018

Comments

@charleshu-8
Copy link
Contributor 

          yazl does not seem to be maintained any longer.  we should look into a replacement lib to handle zip files

but also why do we need it at all when we also apparently are using adm-zip which is also a zip library?

admittedly it seems like adm-zip is also probably not being maintained

Originally posted by @Amndeep7 in #3850 (comment)
@charleshu-8 charleshu-8 changed the title yazl does not seem to be maintained any longer. we should look into a replacement lib to handle zip files Should look into a replacement lib to handle zip files Aug 25, 2023
@charleshu-8
Copy link
Contributor Author

@types/yazl has been removed.

@Amndeep7
Copy link
Contributor

image

this is also a thing that webpack complains about. the dependency isn't included because it's only used in electron builds. there's a way to silence the issue, but like i said earlier i'd rather just swap out this lib entirely if possible.

@Amndeep7 Amndeep7 linked a pull request Jul 31, 2024 that will close this issue
Swapped adm-zip out for zip.js #6018
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swapped adm-zip out for zip.js mitre/heimdall2
2 participants
@Amndeep7 @charleshu-8