-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathapi_test.py
561 lines (514 loc) · 21 KB
/
api_test.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
"""Courses API tests"""
import contextlib
from datetime import timedelta
from types import SimpleNamespace
import factory
import pytest
from django.core.exceptions import ValidationError
from requests import ConnectionError as RequestsConnectionError
from requests import HTTPError
from courses.api import (
create_program_enrollments,
create_run_enrollments,
deactivate_program_enrollment,
deactivate_run_enrollment,
defer_enrollment,
generate_course_readable_id,
get_user_enrollments,
)
from courses.constants import (
ENROLL_CHANGE_STATUS_DEFERRED,
ENROLL_CHANGE_STATUS_REFUNDED,
)
from courses.factories import (
CourseFactory,
CourseRunEnrollmentFactory,
CourseRunFactory,
ProgramEnrollmentFactory,
ProgramFactory,
)
from courses.models import CourseRunEnrollment, ProgramEnrollment
from courseware.exceptions import (
EdxApiEnrollErrorException,
EdxEnrollmentCreateError,
NoEdxApiAuthError,
OpenEdXOAuth2Error,
UnknownEdxApiEnrollException,
)
from ecommerce.factories import CompanyFactory, OrderFactory
from mitxpro.test_utils import MockHttpError
from mitxpro.utils import now_in_utc
@pytest.mark.django_db
def test_get_user_enrollments(user):
"""Test that get_user_enrollments returns an object with a user's program and course enrollments"""
past_date = now_in_utc() - timedelta(days=1)
past_start_dates = [
now_in_utc() - timedelta(days=2),
now_in_utc() - timedelta(days=3),
now_in_utc() - timedelta(days=4),
]
program = ProgramFactory.create()
past_program = ProgramFactory.create()
program_course_runs = CourseRunFactory.create_batch(3, course__program=program)
past_program_course_runs = CourseRunFactory.create_batch(
3,
start_date=factory.Iterator(past_start_dates),
end_date=past_date,
course__program=past_program,
)
non_program_course_runs = CourseRunFactory.create_batch(2, course__program=None)
past_non_program_course_runs = CourseRunFactory.create_batch(
2,
start_date=factory.Iterator(past_start_dates),
end_date=past_date,
course__program=None,
)
all_course_runs = (
program_course_runs
+ past_program_course_runs
+ non_program_course_runs
+ past_non_program_course_runs
)
course_run_enrollments = CourseRunEnrollmentFactory.create_batch(
len(all_course_runs), run=factory.Iterator(all_course_runs), user=user
)
program_enrollment = ProgramEnrollmentFactory.create(program=program, user=user)
past_program_enrollment = ProgramEnrollmentFactory.create(
program=past_program, user=user
)
# Add a non-active enrollment so we can confirm that it isn't returned
CourseRunEnrollmentFactory.create(user=user, active=False)
def key_func(enrollment):
"""Function for sorting runs by start_date"""
return enrollment.run.start_date
user_enrollments = get_user_enrollments(user)
assert list(user_enrollments.programs) == [program_enrollment]
assert list(user_enrollments.past_programs) == [past_program_enrollment]
assert list(user_enrollments.program_runs) == sorted(
[
run_enrollment
for run_enrollment in course_run_enrollments
if run_enrollment.run in program_course_runs + past_program_course_runs
],
key=key_func,
)
assert list(user_enrollments.non_program_runs) == sorted(
[
run_enrollment
for run_enrollment in course_run_enrollments
if run_enrollment.run in non_program_course_runs
],
key=key_func,
)
assert list(user_enrollments.past_non_program_runs) == sorted(
[
run_enrollment
for run_enrollment in course_run_enrollments
if run_enrollment.run in past_non_program_course_runs
],
key=key_func,
)
@pytest.mark.django_db
def test_create_run_enrollments(mocker, user):
"""
create_run_enrollments should call the edX API to create enrollments, create or reactivate local
enrollment records, and notify enrolled users via email
"""
num_runs = 3
order = OrderFactory.create()
company = CompanyFactory.create()
runs = CourseRunFactory.create_batch(num_runs)
# Create an existing deactivate enrollment to test that it gets reactivated
CourseRunEnrollmentFactory.create(
user=user,
run=runs[0],
order=order,
change_status=ENROLL_CHANGE_STATUS_REFUNDED,
active=False,
)
patched_edx_enroll = mocker.patch("courses.api.enroll_in_edx_course_runs")
patched_send_enrollment_welcome_email = mocker.patch(
"courses.api.mail_api.send_course_run_enrollment_welcome_email"
)
successful_enrollments, edx_request_success = create_run_enrollments(
user, runs, order=order, company=company
)
patched_edx_enroll.assert_called_once_with(user, runs)
assert patched_send_enrollment_welcome_email.call_count == num_runs
assert edx_request_success is True
assert len(successful_enrollments) == num_runs
enrollments = CourseRunEnrollment.objects.order_by("run__id").all()
for run, enrollment in zip(runs, enrollments):
assert enrollment.change_status is None
assert enrollment.active is True
assert enrollment.edx_enrolled is True
assert enrollment.run == run
patched_send_enrollment_welcome_email.assert_any_call(enrollment)
@pytest.mark.django_db
@pytest.mark.parametrize(
"exception_cls",
[NoEdxApiAuthError, HTTPError, RequestsConnectionError, OpenEdXOAuth2Error],
)
def test_create_run_enrollments_api_fail(mocker, user, exception_cls):
"""
create_run_enrollments should log a message and still create local enrollment records when certain exceptions
are raised if a flag is set to true
"""
patched_edx_enroll = mocker.patch(
"courses.api.enroll_in_edx_course_runs", side_effect=exception_cls
)
patched_log_exception = mocker.patch("courses.api.log.exception")
patched_send_enrollment_welcome_email = mocker.patch(
"courses.api.mail_api.send_course_run_enrollment_welcome_email"
)
run = CourseRunFactory.create()
successful_enrollments, edx_request_success = create_run_enrollments(
user,
[run],
order=None,
company=None,
keep_failed_enrollments=True,
)
patched_edx_enroll.assert_called_once_with(user, [run])
patched_log_exception.assert_called_once()
patched_send_enrollment_welcome_email.assert_not_called()
assert len(successful_enrollments) == 1
assert edx_request_success is False
@pytest.mark.django_db
@pytest.mark.parametrize("keep_failed_enrollments", [True, False])
@pytest.mark.parametrize(
"exception_cls,inner_exception", # noqa: PT006
[
[EdxApiEnrollErrorException, MockHttpError()], # noqa: PT007
[UnknownEdxApiEnrollException, Exception()], # noqa: PT007
],
)
def test_create_run_enrollments_enroll_api_fail(
mocker,
user,
keep_failed_enrollments,
exception_cls,
inner_exception,
):
"""
create_run_enrollments should log a message and still create local enrollment records when an enrollment exception
is raised if a flag is set to true
"""
num_runs = 3
runs = CourseRunFactory.create_batch(num_runs)
patched_edx_enroll = mocker.patch(
"courses.api.enroll_in_edx_course_runs",
side_effect=exception_cls(user, runs[2], inner_exception),
)
patched_log_exception = mocker.patch("courses.api.log.exception")
patched_send_enrollment_welcome_email = mocker.patch(
"courses.api.mail_api.send_course_run_enrollment_welcome_email"
)
successful_enrollments = []
edx_request_success = False
with (
pytest.raises(EdxEnrollmentCreateError)
if not keep_failed_enrollments
else contextlib.suppress(EdxEnrollmentCreateError)
):
successful_enrollments, edx_request_success = create_run_enrollments(
user,
runs,
order=None,
company=None,
keep_failed_enrollments=keep_failed_enrollments,
)
patched_edx_enroll.assert_called_once_with(user, runs)
if keep_failed_enrollments:
patched_log_exception.assert_called_once()
else:
patched_log_exception.assert_not_called()
patched_send_enrollment_welcome_email.assert_not_called()
expected_enrollments = 0 if not keep_failed_enrollments else num_runs
assert len(successful_enrollments) == expected_enrollments
assert edx_request_success is False
@pytest.mark.django_db
def test_create_run_enrollments_creation_fail(mocker, user):
"""
create_run_enrollments should log a message and send an admin email if there's an error during the
creation of local enrollment records
"""
runs = CourseRunFactory.create_batch(2)
enrollment = CourseRunEnrollmentFactory.build(run=runs[1])
mocker.patch(
"courses.api.CourseRunEnrollment.all_objects.get_or_create",
side_effect=[Exception(), (enrollment, True)],
)
patched_edx_enroll = mocker.patch("courses.api.enroll_in_edx_course_runs")
patched_log_exception = mocker.patch("courses.api.log.exception")
patched_mail_api = mocker.patch("courses.api.mail_api")
successful_enrollments, edx_request_success = create_run_enrollments(
user, runs, order=None, company=None
)
patched_edx_enroll.assert_called_once_with(user, runs)
patched_log_exception.assert_called_once()
patched_mail_api.send_course_run_enrollment_welcome_email.assert_not_called()
patched_mail_api.send_enrollment_failure_message.assert_called_once()
assert successful_enrollments == [enrollment]
assert edx_request_success is True
@pytest.mark.django_db
def test_create_program_enrollments(user):
"""
create_program_enrollments should create or reactivate local enrollment records
"""
num_programs = 2
order = OrderFactory.create()
company = CompanyFactory.create()
programs = ProgramFactory.create_batch(num_programs)
# Create an existing deactivate enrollment to test that it gets reactivated
ProgramEnrollmentFactory.create(
user=user,
program=programs[0],
order=order,
change_status=ENROLL_CHANGE_STATUS_REFUNDED,
active=False,
)
successful_enrollments = create_program_enrollments(
user, programs, order=order, company=company
)
assert len(successful_enrollments) == num_programs
enrollments = ProgramEnrollment.objects.order_by("program__id").all()
assert len(enrollments) == len(programs)
for program, enrollment in zip(programs, enrollments):
assert enrollment.change_status is None
assert enrollment.active is True
assert enrollment.program == program
@pytest.mark.django_db
def test_create_program_enrollments_creation_fail(mocker, user):
"""
create_program_enrollments should log a message and send an admin email if there's an error during the
creation of local enrollment records
"""
programs = ProgramFactory.create_batch(2)
enrollment = ProgramEnrollmentFactory.build(program=programs[1])
mocker.patch(
"courses.api.ProgramEnrollment.all_objects.get_or_create",
side_effect=[Exception(), (enrollment, True)],
)
patched_log_exception = mocker.patch("courses.api.log.exception")
patched_mail_api = mocker.patch("courses.api.mail_api")
successful_enrollments = create_program_enrollments(
user, programs, order=None, company=None
)
patched_log_exception.assert_called_once()
patched_mail_api.send_enrollment_failure_message.assert_called_once()
assert successful_enrollments == [enrollment]
class TestDeactivateEnrollments:
"""Test cases for functions that deactivate enrollments"""
@pytest.fixture
def patches(self, mocker):
edx_unenroll = mocker.patch("courses.api.unenroll_edx_course_run")
send_unenrollment_email = mocker.patch(
"courses.api.mail_api.send_course_run_unenrollment_email"
)
log_exception = mocker.patch("courses.api.log.exception")
return SimpleNamespace(
edx_unenroll=edx_unenroll,
send_unenrollment_email=send_unenrollment_email,
log_exception=log_exception,
)
@pytest.mark.django_db
def test_deactivate_run_enrollment(self, patches):
"""
deactivate_run_enrollment should attempt to unenroll a user in a course run in edX and set the
local enrollment record to inactive
"""
enrollment = CourseRunEnrollmentFactory.create(edx_enrolled=True)
returned_enrollment = deactivate_run_enrollment(
enrollment, change_status=ENROLL_CHANGE_STATUS_REFUNDED
)
patches.edx_unenroll.assert_called_once_with(enrollment)
patches.send_unenrollment_email.assert_called_once_with(enrollment)
enrollment.refresh_from_db()
assert enrollment.change_status == ENROLL_CHANGE_STATUS_REFUNDED
assert enrollment.active is False
assert enrollment.edx_enrolled is False
assert returned_enrollment == enrollment
@pytest.mark.parametrize("keep_failed_enrollments", [True, False])
@pytest.mark.django_db
def test_deactivate_run_enrollment_api_fail(self, patches, keep_failed_enrollments):
"""
If a flag is provided, deactivate_run_enrollment should set local enrollment record to inactive even if the API call fails
"""
enrollment = CourseRunEnrollmentFactory.create(edx_enrolled=True)
patches.edx_unenroll.side_effect = Exception
deactivate_run_enrollment(
enrollment,
change_status=ENROLL_CHANGE_STATUS_REFUNDED,
keep_failed_enrollments=keep_failed_enrollments,
)
patches.edx_unenroll.assert_called_once_with(enrollment)
patches.send_unenrollment_email.assert_not_called()
patches.log_exception.assert_called_once()
enrollment.refresh_from_db()
assert enrollment.active is not keep_failed_enrollments
@pytest.mark.django_db
def test_deactivate_program_enrollment(self, user, patches):
"""
deactivate_program_enrollment set the local program enrollment record to inactive as well as all
associated course run enrollments
"""
order = OrderFactory.create()
program_enrollment = ProgramEnrollmentFactory.create(user=user, order=order)
course = CourseFactory.create(program=program_enrollment.program)
course_run_enrollments = CourseRunEnrollmentFactory.create_batch(
3,
user=user,
run__course=course,
active=True,
order=factory.Iterator([order, order, None]),
)
expected_inactive_run_enrollments = course_run_enrollments[0:2]
expected_ignored_run_enrollment = course_run_enrollments[2]
(
returned_program_enrollment,
returned_run_enrollments,
) = deactivate_program_enrollment(
program_enrollment, change_status=ENROLL_CHANGE_STATUS_REFUNDED
)
program_enrollment.refresh_from_db()
assert program_enrollment.change_status == ENROLL_CHANGE_STATUS_REFUNDED
assert program_enrollment.active is False
assert returned_program_enrollment == program_enrollment
assert {e.id for e in returned_run_enrollments} == {
e.id for e in expected_inactive_run_enrollments
}
assert patches.edx_unenroll.call_count == len(expected_inactive_run_enrollments)
assert patches.send_unenrollment_email.call_count == len(
expected_inactive_run_enrollments
)
for run_enrollment in expected_inactive_run_enrollments:
run_enrollment.refresh_from_db()
assert run_enrollment.change_status == ENROLL_CHANGE_STATUS_REFUNDED
assert run_enrollment.active is False
assert expected_ignored_run_enrollment.active is True
@pytest.mark.parametrize("keep_failed_enrollments", [True, False])
@pytest.mark.parametrize("force_enrollment", [True, False])
@pytest.mark.django_db
def test_defer_enrollment(mocker, keep_failed_enrollments, force_enrollment):
"""
defer_enrollment should deactivate a user's existing enrollment and create an enrollment in another
course run
"""
course = CourseFactory.create()
course_runs = CourseRunFactory.create_batch(3, course=course)
order = OrderFactory.create()
company = CompanyFactory.create()
existing_enrollment = CourseRunEnrollmentFactory.create(
run=course_runs[0], order=order, company=company
)
target_run = course_runs[1]
mock_new_enrollment = mocker.Mock()
patched_create_enrollments = mocker.patch(
"courses.api.create_run_enrollments",
autospec=True,
return_value=([mock_new_enrollment if keep_failed_enrollments else None], True),
)
patched_deactivate_enrollments = mocker.patch(
"courses.api.deactivate_run_enrollment",
autospec=True,
return_value=existing_enrollment if keep_failed_enrollments else None,
)
returned_from_enrollment, returned_to_enrollment = defer_enrollment(
existing_enrollment.user,
existing_enrollment.run.courseware_id,
course_runs[1].courseware_id,
keep_failed_enrollments=keep_failed_enrollments,
force=force_enrollment,
)
assert returned_from_enrollment == patched_deactivate_enrollments.return_value
assert returned_to_enrollment == patched_create_enrollments.return_value[0][0]
patched_create_enrollments.assert_called_once_with(
existing_enrollment.user,
[target_run],
order=order,
company=company,
keep_failed_enrollments=keep_failed_enrollments,
)
patched_deactivate_enrollments.assert_called_once_with(
existing_enrollment,
ENROLL_CHANGE_STATUS_DEFERRED,
keep_failed_enrollments=keep_failed_enrollments,
)
@pytest.mark.django_db
def test_defer_enrollment_validation(mocker, user):
"""
defer_enrollment should raise an exception if the 'from' or 'to' course runs are invalid
"""
courses = CourseFactory.create_batch(2)
enrollments = CourseRunEnrollmentFactory.create_batch(
3,
user=user,
active=factory.Iterator([False, True, True]),
run__course=factory.Iterator([courses[0], courses[0], courses[1]]),
)
unenrollable_run = CourseRunFactory.create(
enrollment_end=now_in_utc() - timedelta(days=1)
)
patched_create_enrollments = mocker.patch(
"courses.api.create_run_enrollments", return_value=([], False)
)
mocker.patch("courses.api.deactivate_run_enrollment", return_value=[])
with pytest.raises(ValidationError):
# Deferring to the same course run should raise a validation error
defer_enrollment(
user, enrollments[0].run.courseware_id, enrollments[0].run.courseware_id
)
patched_create_enrollments.assert_not_called()
with pytest.raises(ValidationError):
# Deferring to a course run that is outside of its enrollment period should raise a validation error
defer_enrollment(
user, enrollments[0].run.courseware_id, unenrollable_run.courseware_id
)
patched_create_enrollments.assert_not_called()
with pytest.raises(ValidationError):
# Deferring from an inactive enrollment should raise a validation error
defer_enrollment(
user, enrollments[0].run.courseware_id, enrollments[1].run.courseware_id
)
patched_create_enrollments.assert_not_called()
with pytest.raises(ValidationError):
# Deferring to a course run in a different course should raise a validation error
defer_enrollment(
user, enrollments[1].run.courseware_id, enrollments[2].run.courseware_id
)
patched_create_enrollments.assert_not_called()
# The last two cases should not raise an exception if the 'force' flag is set to True
defer_enrollment(
user,
enrollments[0].run.courseware_id,
enrollments[1].run.courseware_id,
force=True,
)
assert patched_create_enrollments.call_count == 1
defer_enrollment(
user,
enrollments[1].run.courseware_id,
enrollments[2].run.courseware_id,
force=True,
)
assert patched_create_enrollments.call_count == 2
@pytest.mark.parametrize(
("course_tag", "expected_readable_id", "raises_validation_error"),
[
("DBIP", "course-v1:xPRO+DBIP", False),
("DBIP.ES", "course-v1:xPRO+DBIP.ES", False),
("DBIP.SEPO", "course-v1:xPRO+DBIP.SEPO", False),
("", "", True),
(None, None, True),
],
)
def test_generate_course_readable_id(
course_tag, expected_readable_id, raises_validation_error
):
"""Test that `generate_course_readable_id` returns expected course readable_id for course tags."""
if raises_validation_error:
with pytest.raises(ValidationError):
generate_course_readable_id(course_tag)
else:
assert generate_course_readable_id(course_tag) == expected_readable_id