Catalog Update without having to hit bottom of page #2076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment in CourseProductDetailEnroll_test.js to facilitate splitting tests per render method
…over to a separate block which calls deeprender only. Have to put changes back in to fix teh generated course data and should be set.
…ior, shallowly, ignoring any calls. we otherwise test that these components are working with redux (which is what makes those calls that were previously asserted by sinon. Now I'm taking those as fact since we want to test the behavior of this component with the information provided, this is a shallow render, ignoring those calls (and un-complicating the test)
This reverts commit fd4163f.
# Conflicts: # frontend/public/src/components/CourseProductDetailEnroll.js # frontend/public/src/components/CourseProductDetailEnroll_test.js # frontend/public/src/components/NotificationContainer_test.js # frontend/public/src/containers/UpsellCardApp.js
… loading the second set again
annagav
requested changes
Feb 12, 2024
| { threshold: 1.0 } | ||
| ) | ||
| this.io.observe(this.container.current) | ||
| console.log("gets here") |
| if (!coursesIsLoading) { | ||
| if (this.props.courses.length < this.props.coursesCount) { | ||
| const response = await getNextCoursePage(this.state.courseQueryPage + 1) | ||
| console.log(response) |
| @@ -464,6 +409,10 @@ export class CatalogPage extends React.Component<Props> { | |||
| ) | |||
| } | |||
|
|
|||
| async loadMorePrograms() { | |||
|
It says the page is unresponsive. This happened only after I created over 12 items for the page. |
|
Closing as this was fixed in #2130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
fixes https://github.com/mitodl/hq/issues/3141
fixes https://github.com/mitodl/hq/issues/2992
fixes https://github.com/mitodl/hq/issues/2910
fixes https://github.com/mitodl/hq/issues/2909
Description (What does it do?)
Rather than relying on the page scroll to load more, there is a chain of requests to fill out the data for the page until it is full, regardless of page movement, once the initial load is complete.
How can this be tested?
Set up data with more than 12 courses and/or programs (ideally both). You will want a few departments loaded as well. Load the catalog and click to filter the list. You should get all cards loading in.