Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the Catalog shows same info for course run as the product page #2360

Closed
annagav opened this issue Aug 26, 2024 · 1 comment · Fixed by #2363
Closed

Make sure that the Catalog shows same info for course run as the product page #2360

annagav opened this issue Aug 26, 2024 · 1 comment · Fixed by #2363
Assignees

Comments

@annagav
Copy link
Contributor

annagav commented Aug 26, 2024

As I was working on this #2359 I looked through the catalog course card and it looked like the first relevant run for which we show info is not similar to the logic we use for picking first relevant run for the product page.

@annagav annagav self-assigned this Aug 27, 2024
@annagav
Copy link
Contributor Author

annagav commented Aug 27, 2024

So for the catalog (Course.first_unexpired_run):
we pick the earliest starting or started course run that is enrollable (non-archived preferred).

In the Course product page we are picking the run with the start date that is closest to now (if course.next_run_id is null).

Could not explain why we have getFirstRelevantRun calculation in the front end, if we are already passing next_run_id in the courses api. This is probably ready for some refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant