You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 16, 2018. It is now read-only.
We currently use Array.sort in in ducks/utils/store.js, which is a bad idea because it's unstable. We should instead use _.sortBy and adjust makeSort in ducks/flows.js accordingly.
The text was updated successfully, but these errors were encountered:
sorry for the really late response. _.sortBy does not accept a compare function as Array.sort does, while we are using the compare function everywhere. How about including a new dependency: stable, so that we can preserve our code structure and get the stable sorting.
Hm, it's a bit stupid because we go through the tedious process of creating a sorting function here only to then need to work around it. 😅
It's probably not much harder to makeSort -> makeSortKey?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We currently use Array.sort in in ducks/utils/store.js, which is a bad idea because it's unstable. We should instead use
_.sortBy
and adjust makeSort inducks/flows.js
accordingly.The text was updated successfully, but these errors were encountered: