Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnp2p should care less about transport layer #430

Open
delbonis opened this issue Nov 20, 2018 · 2 comments
Open

lnp2p should care less about transport layer #430

delbonis opened this issue Nov 20, 2018 · 2 comments
Labels
refactoring Significant changes to existing code to improve robustness/performance

Comments

@delbonis
Copy link
Collaborator

delbonis commented Nov 20, 2018

We should already verify the pubkey before calling handleNewConnection and it should pass that in as an argument instead of having it there. We should try to isolate stuff interacting with lndc to probably just listen.go and move the "connecting to peers" code to like connect.go.

Really we should just move listening setup code to just pass in an already-ready net.Listener into the lnp2p.NewPeerManager function. Really just do more work to make lnp2p more separated from the rest of the network code.

This would be necessary for having BOLT 8 (transport) and BOLT 1 (messaging) support.

@delbonis delbonis added the refactoring Significant changes to existing code to improve robustness/performance label Nov 20, 2018
@delbonis
Copy link
Collaborator Author

See #440, that PR is related to this because it's a step towards splitting up connection and session management.

@Varunram
Copy link
Contributor

Varunram commented Dec 2, 2018

Depends on how we proceed with implementing BOLT1 and relatives into lit as well, but #440 is a nice start towards the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Significant changes to existing code to improve robustness/performance
Projects
None yet
Development

No branches or pull requests

2 participants