Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dose it support umd way? #76

Open
1 task done
mlzboy opened this issue Aug 27, 2024 · 3 comments
Open
1 task done

dose it support umd way? #76

mlzboy opened this issue Aug 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@mlzboy
Copy link

mlzboy commented Aug 27, 2024

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

https://codepen.io/mlzboy/pen/ZEdRdrw?editors=1010
write a snippet code with claude seems not work
image

Reproduction steps

Stack trace

No response

Screenshots

No response

Browsers

No response

@mlzboy mlzboy added the bug Something isn't working label Aug 27, 2024
@HollowMan6
Copy link
Collaborator

No, it's an ESM module. I think it should be enough for most people and I don't have plans for UMD, but if you are interested, you are welcome to submit a PR and configure it as a dual ESM + UMD package.

@HollowMan6 HollowMan6 added enhancement New feature or request and removed bug Something isn't working labels Aug 27, 2024
@mlzboy
Copy link
Author

mlzboy commented Aug 28, 2024

I used this module old version in blockly 9 with umd support ...
but after use this module ,workspace.getTopBlocks(true).length will not work as expect,when I drag a block from toolbox into workspace it will append to topblocks twice.but workspace.getAllBlocks(true).length works fine.so I want to check the new version dose any change for fix this issue

@HollowMan6
Copy link
Collaborator

HollowMan6 commented Aug 28, 2024

I used this module old version in blockly 9 with umd support ...

Oh really, that would be the intial version of this plugin, which I don’t remember I did anything specifically to support UMD. If you have any ideas for how to restore that support, feel free to send a PR.

but after use this module
,workspace.getTopBlocks(true).length will not work as expect,when I drag a block from toolbox into workspace it will append to topblocks twice.but workspace.getAllBlocks(true).length works fine.so I want to check the new version dose any change for fix this issue

EDIT: Ah, you mean you have this issue in the old versions of this plugin? Then it's probably fixed since the new version switched to IDraggable.

That sounds like a Blockly issue, maybe they have some bugs counting the blocks when we have customized IDraggable, I would suggest you to open an issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants