Revert 8e53443 - adding default cases

Too noisy for unreachable code.

Author: dajobe

src/rasqal_literal.c

@@ -510,7 +510,6 @@ rasqal_new_numeric_literal(rasqal_world* world, rasqal_literal_type type,
     case RASQAL_LITERAL_QNAME:
     case RASQAL_LITERAL_VARIABLE:
     case RASQAL_LITERAL_UDT:
-    default:
       RASQAL_FATAL2("Unexpected numeric type %u", type);
   }
 

src/rasqal_query.c

@@ -311,8 +311,6 @@ rasqal_query_set_feature(rasqal_query* query, rasqal_feature feature, int value)
 
       query->features[RASQAL_GOOD_CAST(int, feature)] = value;
       break;
-    default:
-      return -1;
   }
 
   return 0;
@@ -374,8 +372,6 @@ rasqal_query_get_feature(rasqal_query *query, rasqal_feature feature)
     case RASQAL_FEATURE_RAND_SEED:
       result = (query->features[RASQAL_GOOD_CAST(int, feature)] != 0);
       break;
-    default:
-      return -1;
   }
 
   return result;

src/rasqal_query_transform.c

@@ -1637,7 +1637,6 @@ rasqal_query_graph_pattern_build_variables_use_map(rasqal_query* query,
     case RASQAL_GRAPH_PATTERN_OPERATOR_MINUS:
     case RASQAL_GRAPH_PATTERN_OPERATOR_VALUES:
     case RASQAL_GRAPH_PATTERN_OPERATOR_UNKNOWN:
-    default:
       break;
   }
 
@@ -1950,7 +1949,6 @@ rasqal_query_graph_pattern_build_variables_use_map_binds(rasqal_query* query,
     case RASQAL_GRAPH_PATTERN_OPERATOR_SERVICE:
     case RASQAL_GRAPH_PATTERN_OPERATOR_MINUS:
     case RASQAL_GRAPH_PATTERN_OPERATOR_UNKNOWN:
-    default:
       break;
   }
 

src/rasqal_query_write.c

@@ -994,9 +994,8 @@ rasqal_query_write_graphref(sparql_writer_context* wc,
     case RASQAL_UPDATE_GRAPH_ALL:
       raptor_iostream_counted_string_write(" ALL", 4, iostr);
       break;
-
-    default:
-      break;
+      
+    /* default: case not necessary */
   }
 
   return 0;

src/rasqal_result_formats.c

@@ -614,7 +614,6 @@ rasqal_query_results_formatter_read(rasqal_world *world,
     case RASQAL_QUERY_RESULTS_GRAPH:
     case RASQAL_QUERY_RESULTS_SYNTAX:
     case RASQAL_QUERY_RESULTS_UNKNOWN:
-    default:
       /* failure */
       rasqal_log_error_simple(world, RAPTOR_LOG_LEVEL_ERROR, NULL,
                               "Cannot read '%s' query results format\n",

src/rasqal_update.c

@@ -199,9 +199,6 @@ rasqal_update_operation_print(rasqal_update_operation *update, FILE* stream)
     case RASQAL_UPDATE_GRAPH_ALL:
       fputs(", applies: all", stream);
       break;
-
-    default:
-      break;
   }
 
   if(update->insert_templates) {

utils/check_query.c

@@ -256,6 +256,11 @@ main(int argc, char *argv[])
       break;
 
     switch (c) {
+      case 0:
+      case '?': /* getopt() - unknown option */
+        usage = 1;
+        break;
+        
       case 'd':
         verbose++;
         break;
@@ -337,12 +342,6 @@ main(int argc, char *argv[])
         }
         break;
 
-      case 0:
-      case '?': /* getopt() - unknown option */
-      default:
-        usage = 1;
-        break;
-        
     }
 
   } /* end while option */
@@ -593,7 +592,6 @@ main(int argc, char *argv[])
 
       case RASQAL_QUERY_RESULTS_SYNTAX:
       case RASQAL_QUERY_RESULTS_UNKNOWN:
-      default:
         /* failure */
         fprintf(stderr,
                 "%s: Reading %s query results format is not supported",
@@ -655,7 +653,6 @@ main(int argc, char *argv[])
       case RASQAL_QUERY_RESULTS_GRAPH:
       case RASQAL_QUERY_RESULTS_SYNTAX:
       case RASQAL_QUERY_RESULTS_UNKNOWN:
-      default:
         /* failure */
         fprintf(stderr, "%s: Query result format %u cannot be tested.", 
                 program, results_type);

utils/roqet.c

@@ -168,7 +168,6 @@ roqet_log_handler(void *data, raptor_log_message *message)
     case RAPTOR_LOG_LEVEL_TRACE:
     case RAPTOR_LOG_LEVEL_DEBUG:
     case RAPTOR_LOG_LEVEL_INFO:
-    default:
 
       fprintf(stderr, "%s: Unexpected %s message - ", program,
               raptor_log_level_get_label(message->level));
@@ -940,6 +939,11 @@ main(int argc, char *argv[])
       break;
 
     switch (c) {
+      case 0:
+      case '?': /* getopt() - unknown option */
+        usage = 1;
+        break;
+        
       case 'c':
         count = 1;
         break;
@@ -1191,11 +1195,6 @@ main(int argc, char *argv[])
         break;
 #endif
 
-      case 0:
-      case '?': /* getopt() - unknown option */
-      default:
-        usage = 1;
-        break;
     }
 
   }
@@ -1434,7 +1433,6 @@ main(int argc, char *argv[])
 
 
     case MODE_EXEC_UNKNOWN:
-    default:
       break;
   }
 

utils/to-ntriples.c

@@ -89,7 +89,7 @@ to_ntriples_log_handler(void *data, raptor_log_message *message)
     case RAPTOR_LOG_LEVEL_TRACE:
     case RAPTOR_LOG_LEVEL_DEBUG:
     case RAPTOR_LOG_LEVEL_INFO:
-    default:
+
       fprintf(stderr, "%s: Unexpected %s message - ", program,
               raptor_log_level_get_label(message->level));
       raptor_locator_print(message->locator, stderr);