Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Open Task] Add tests #19

Open
misteu opened this issue Oct 11, 2022 · 2 comments
Open

[Open Task] Add tests #19

misteu opened this issue Oct 11, 2022 · 2 comments

Comments

@misteu
Copy link
Owner

misteu commented Oct 11, 2022

GOAL

The app's code should be covered with tests.

WHY

Currently, the app is not tested at all.

ACCEPTANCE CRITERIA

Add tests for any parts of the app. Please start with Unit tests of critical parts of the app (e.g. saving, loading vocabulary). UI tests are not a priority right now.

  1. Let me know (comment here) for which part(s) you want to add tests
  2. I'll create an issue for you and assign you to that issue
  3. Create a PR with your changes. If you had to make any changes to the actual code (e.g. to make it testable) please add this in the PR. Please do not just refactor parts of the code for the sake of it. We can safely do that as soon as tests are there :)
@yogesh-9999
Copy link

Hey @misteu assign this to me

@misteu
Copy link
Owner Author

misteu commented Oct 11, 2022

Hey @yogesh-9999
Please focus on one issue after another. I assigned you already to #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants