Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning doesn't work if mix public path is not set correctly - mix.setPublicPath() #22

Open
amkdev opened this issue Dec 5, 2022 · 0 comments

Comments

@amkdev
Copy link

amkdev commented Dec 5, 2022

The plugin assumes that the mix-manifest.json and the asset files are in the same directory. This can lead to problems, because it requires that mix.setPublicPath() is set correctly in the webpack.mix.js configuration first. If not, the user really doesn't know why the plugin doesn't work!

I think the idea of the asset path setting is addressing this issue (to be able to use mix.setPublicPath()), but it's misleading to the user. It looks like this is simply to shorten the asset file path for the Twig function mix() only.

It should be mentioned that you have to set the mix public path in your mix config exactly like this ... or there should be an additional path setting for the manifest file!

Also configuring via a php file in config/ (as is common with other plugins) would be nice.

BTW: is the public path setting really necessary? Craft offers this information internally imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant