Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postcode CV33 Issue #11

Open
ro2wida opened this issue Oct 17, 2024 · 7 comments
Open

Postcode CV33 Issue #11

ro2wida opened this issue Oct 17, 2024 · 7 comments

Comments

@ro2wida
Copy link

ro2wida commented Oct 17, 2024

The polygon is not closing it properly. I used turf library to get the difference of the area. This is the new polygon if someone needs it

{
  "type": "Feature",
  "geometry": {
    "type": "Polygon",
    "coordinates": [
      [
        [
          -1.57439,
          52.24933
        ],
        [
          -1.56412,
          52.24311
        ],
        [
          -1.56212,
          52.24008
        ],
        [
          -1.56854,
          52.23408
        ],
        [
          -1.56367,
          52.23013
        ],
        [
          -1.55673,
          52.22867
        ],
        [
          -1.55382,
          52.22869
        ],
        [
          -1.55317,
          52.22095
        ],
        [
          -1.54552,
          52.21986
        ],
        [
          -1.54426,
          52.22109
        ],
        [
          -1.53373,
          52.22366
        ],
        [
          -1.53215,
          52.22739
        ],
        [
          -1.52239,
          52.22985
        ],
        [
          -1.51864,
          52.22495
        ],
        [
          -1.51901,
          52.22407
        ],
        [
          -1.51601,
          52.21551
        ],
        [
          -1.51569,
          52.21543
        ],
        [
          -1.51365,
          52.21544
        ],
        [
          -1.50517,
          52.22224
        ],
        [
          -1.5026,
          52.22274
        ],
        [
          -1.49591,
          52.2178
        ],
        [
          -1.49329,
          52.2133
        ],
        [
          -1.493,
          52.2131
        ],
        [
          -1.47607,
          52.21217
        ],
        [
          -1.47155,
          52.20727
        ],
        [
          -1.48387,
          52.20431
        ],
        [
          -1.48791,
          52.20368
        ],
        [
          -1.4966,
          52.2033
        ],
        [
          -1.49582,
          52.20186
        ],
        [
          -1.49558,
          52.1978
        ],
        [
          -1.49583,
          52.19581
        ],
        [
          -1.49636,
          52.19471
        ],
        [
          -1.49687,
          52.19373
        ],
        [
          -1.49334,
          52.19154
        ],
        [
          -1.48528,
          52.19614
        ],
        [
          -1.48549,
          52.19636
        ],
        [
          -1.48552,
          52.19798
        ],
        [
          -1.48539,
          52.19805
        ],
        [
          -1.4855,
          52.19859
        ],
        [
          -1.48501,
          52.19887
        ],
        [
          -1.47487,
          52.20079
        ],
        [
          -1.47299,
          52.2021
        ],
        [
          -1.48563,
          52.19984
        ],
        [
          -1.48586,
          52.19975
        ],
        [
          -1.48725,
          52.2001
        ],
        [
          -1.48708,
          52.20051
        ],
        [
          -1.48669,
          52.20071
        ],
        [
          -1.48668,
          52.20072
        ],
        [
          -1.47085,
          52.20676
        ],
        [
          -1.4682,
          52.20504
        ],
        [
          -1.46593,
          52.20438
        ],
        [
          -1.46448,
          52.20467
        ],
        [
          -1.45225,
          52.21163
        ],
        [
          -1.44941,
          52.21398
        ],
        [
          -1.44993,
          52.21844
        ],
        [
          -1.44057,
          52.22274
        ],
        [
          -1.43867,
          52.22432
        ],
        [
          -1.43986,
          52.22659
        ],
        [
          -1.44157,
          52.22856
        ],
        [
          -1.44047,
          52.23152
        ],
        [
          -1.44117,
          52.23468
        ],
        [
          -1.44097,
          52.2355
        ],
        [
          -1.43991,
          52.23687
        ],
        [
          -1.43976,
          52.23708
        ],
        [
          -1.43586,
          52.24077
        ],
        [
          -1.43342,
          52.24062
        ],
        [
          -1.41849,
          52.24362
        ],
        [
          -1.41831,
          52.24448
        ],
        [
          -1.4199,
          52.24622
        ],
        [
          -1.42332,
          52.25437
        ],
        [
          -1.42864,
          52.25576
        ],
        [
          -1.43379,
          52.2565
        ],
        [
          -1.43528,
          52.25857
        ],
        [
          -1.43303,
          52.2619
        ],
        [
          -1.43578,
          52.26914
        ],
        [
          -1.44608,
          52.27132
        ],
        [
          -1.44183,
          52.27881
        ],
        [
          -1.44641,
          52.28148
        ],
        [
          -1.44635,
          52.28564
        ],
        [
          -1.44471,
          52.29031
        ],
        [
          -1.44471,
          52.29032
        ],
        [
          -1.44161,
          52.29436
        ],
        [
          -1.44122,
          52.29445
        ],
        [
          -1.44075,
          52.2945
        ],
        [
          -1.42674,
          52.29114
        ],
        [
          -1.41995,
          52.29307
        ],
        [
          -1.42134,
          52.29811
        ],
        [
          -1.41825,
          52.30347
        ],
        [
          -1.42203,
          52.30836
        ],
        [
          -1.42201,
          52.30939
        ],
        [
          -1.41883,
          52.31218
        ],
        [
          -1.41864,
          52.31229
        ],
        [
          -1.41533,
          52.31328
        ],
        [
          -1.4153,
          52.31331
        ],
        [
          -1.41512,
          52.32213
        ],
        [
          -1.41446,
          52.32284
        ],
        [
          -1.42135,
          52.32752
        ],
        [
          -1.42666,
          52.32802
        ],
        [
          -1.42961,
          52.32644
        ],
        [
          -1.43741,
          52.32622
        ],
        [
          -1.44366,
          52.32988
        ],
        [
          -1.45307,
          52.33111
        ],
        [
          -1.45414,
          52.3339
        ],
        [
          -1.46632,
          52.33815
        ],
        [
          -1.48111,
          52.3303
        ],
        [
          -1.48367,
          52.33031
        ],
        [
          -1.48611,
          52.32781
        ],
        [
          -1.47675,
          52.3128
        ],
        [
          -1.47619,
          52.31109
        ],
        [
          -1.47683,
          52.31011
        ],
        [
          -1.4763,
          52.30743
        ],
        [
          -1.48476,
          52.30526
        ],
        [
          -1.487,
          52.30461
        ],
        [
          -1.49027,
          52.3043
        ],
        [
          -1.49225,
          52.30355
        ],
        [
          -1.4971,
          52.29634
        ],
        [
          -1.50257,
          52.29575
        ],
        [
          -1.50693,
          52.29103
        ],
        [
          -1.50684,
          52.28956
        ],
        [
          -1.50603,
          52.28888
        ],
        [
          -1.50507,
          52.28849
        ],
        [
          -1.49975,
          52.28605
        ],
        [
          -1.49559,
          52.28533
        ],
        [
          -1.49507,
          52.28536
        ],
        [
          -1.48787,
          52.288
        ],
        [
          -1.47854,
          52.28245
        ],
        [
          -1.4771,
          52.28081
        ],
        [
          -1.47347,
          52.27982
        ],
        [
          -1.47363,
          52.2761
        ],
        [
          -1.47166,
          52.27362
        ],
        [
          -1.45656,
          52.27073
        ],
        [
          -1.45355,
          52.2684
        ],
        [
          -1.45555,
          52.26701
        ],
        [
          -1.46436,
          52.26595
        ],
        [
          -1.46702,
          52.26503
        ],
        [
          -1.47211,
          52.26195
        ],
        [
          -1.46823,
          52.25609
        ],
        [
          -1.47098,
          52.25352
        ],
        [
          -1.4646,
          52.24561
        ],
        [
          -1.47414,
          52.24234
        ],
        [
          -1.47561,
          52.24203
        ],
        [
          -1.48355,
          52.25011
        ],
        [
          -1.48386,
          52.25009
        ],
        [
          -1.49584,
          52.25325
        ],
        [
          -1.49794,
          52.25288
        ],
        [
          -1.50349,
          52.25339
        ],
        [
          -1.50672,
          52.25496
        ],
        [
          -1.51396,
          52.2538
        ],
        [
          -1.51929,
          52.25222
        ],
        [
          -1.52372,
          52.25707
        ],
        [
          -1.52415,
          52.25719
        ],
        [
          -1.53088,
          52.258
        ],
        [
          -1.53058,
          52.2587
        ],
        [
          -1.53061,
          52.25946
        ],
        [
          -1.53069,
          52.25972
        ],
        [
          -1.53127,
          52.26093
        ],
        [
          -1.53298,
          52.26183
        ],
        [
          -1.5334,
          52.26184
        ],
        [
          -1.53464,
          52.26164
        ],
        [
          -1.53604,
          52.26075
        ],
        [
          -1.53658,
          52.26019
        ],
        [
          -1.53915,
          52.26109
        ],
        [
          -1.54068,
          52.26134
        ],
        [
          -1.54196,
          52.2613
        ],
        [
          -1.54273,
          52.26071
        ],
        [
          -1.5463,
          52.25644
        ],
        [
          -1.54726,
          52.25642
        ],
        [
          -1.54814,
          52.25566
        ],
        [
          -1.54969,
          52.25452
        ],
        [
          -1.55191,
          52.25336
        ],
        [
          -1.55597,
          52.25328
        ],
        [
          -1.55846,
          52.25045
        ],
        [
          -1.57434,
          52.24945
        ],
        [
          -1.57439,
          52.24933
        ]
      ]
    ]
  },
  "properties": {
    "name": "CV33",
    "description": "CV33 postcode district"
  }
}
@missinglink
Copy link
Owner

Could you please fix it on Wikipedia so the source is correct.

Let me know and I'll run a new import.

https://github.com/missinglink/uk-postcode-polygons?tab=readme-ov-file#can-i-submit-a-pull-request

@missinglink
Copy link
Owner

It's possible been fixed already? I didn't check

@ro2wida
Copy link
Author

ro2wida commented Oct 17, 2024

Yes but I don't know where is the Wikipedia source, could you send me the link?

Also, I've noticed another issues with LE10, LE15 & NN14. And some NN polygons have extra coordinates.

I have the polygons already, so I can uploaded to the wiki too.

This repo I pulled yesterday so I don't think is fixed already.

@missinglink
Copy link
Owner

@missinglink
Copy link
Owner

I just ran the script and there was only one change, which was unrelated:
#12

@missinglink missinglink reopened this Oct 17, 2024
@missinglink
Copy link
Owner

Agh, took me a second to find it, I think this is the page you'll need to edit:
https://en.wikipedia.org/w/index.php?title=Template:Attached_KML/CV_postcode_area

@missinglink
Copy link
Owner

I've update the README with more info about editing Wikipedia:
https://github.com/missinglink/uk-postcode-polygons?tab=readme-ov-file#can-i-submit-a-pull-request

Let me know how you get on, it seems a bit tricky because wikipedia uses KML 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants