Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom link renderer broken by changes to previous_or_next_page #649

Open
mislav opened this issue Jun 1, 2023 · 0 comments
Open

Custom link renderer broken by changes to previous_or_next_page #649

mislav opened this issue Jun 1, 2023 · 0 comments

Comments

@mislav
Copy link
Owner

mislav commented Jun 1, 2023

Just FYI this break custom link renderer because it changed the signature.

e.g. https://github.com/bootstrap-ruby/will_paginate-bootstrap/blob/master/lib/bootstrap_pagination/bootstrap_renderer.rb#L37

Originally posted by @ChrisBr in #645 (comment)
@jorg-vr jorg-vr mentioned this issue Jun 6, 2023
Merged
MrSerth added a commit to openHPI/codeocean that referenced this issue Jun 14, 2023
@MrSerth
Overwrite Bootstrap Link Renderer for WillPaginate
61b3c2a 
Without this fix, the new will_paginate version is not compatible with the old version of bootstrap-will_paginate. This issue is also tracked here: mislav/will_paginate#649

Fixes CODEOCEAN-QK
MrSerth added a commit to openHPI/codeocean that referenced this issue Jun 14, 2023
@MrSerth
Overwrite Bootstrap Link Renderer for WillPaginate
d1a0012 
Without this fix, the new will_paginate version is not compatible with the old version of bootstrap-will_paginate. This issue is also tracked here: mislav/will_paginate#649

Fixes CODEOCEAN-QK
@Roguelazer Roguelazer mentioned this issue Aug 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mislav