Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused Functions Definitions Included During Accordion Component Installation via --type accordion Flag #279

Open
MonaAghili opened this issue Jan 19, 2025 · 2 comments
Assignees
Labels
Milestone

Comments

@MonaAghili
Copy link
Member

When installing the accordion component using the --type accordion flag via the CLI, only the accordion component is explicitly installed. However, the issue arises because the native_accordion component is not explicitly installed, yet its colors and related functions are still included in the process. As a result, since no checks were implemented to handle this scenario, the following warning appears:

warning: function item_color/2 is unused
     │
 775 │   defp item_color("default", "natural") do
     │        ~
     │
     └─ lib/test_chelekom_web/components/accordion.ex:775:8: TestChelekomWeb.Components.Accordion (module)
@shahryarjb
Copy link
Member

I do not think it is about our lib, I tested it in MacOs and Ubuntu server and it works.
We should create an issue in Igniter repo

@shahryarjb
Copy link
Member

Based on: ash-project/igniter#201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants