Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

Paywall dismiss button does not work #14

Closed
realcbnewham opened this issue Apr 29, 2024 · 1 comment · Fixed by #15
Closed

Paywall dismiss button does not work #14

realcbnewham opened this issue Apr 29, 2024 · 1 comment · Fixed by #15
Assignees
Labels
bug Something isn't working
Milestone

Comments

@realcbnewham
Copy link

realcbnewham commented Apr 29, 2024

When using the Paywall composable on iOS I observe the following:

  • The shouldDisplayDismissButton works correctly
  • The onDismiss() lambda is called before/as the Paywall dialogue is displayed
  • The onDismiss button (X at top right of dialogue on iOS) does nothing (that is, the lambda is never called)

The dialogue can be dismissed by pulling down on the dialogue, which I presume is how RevenueCat have designed it in case there is no dismiss button.

Not being familiar anymore with Swift (not done it in years) and how it interacts with Kotlin I asked GPT-4 about the KMPRevenueCat Paywall implementation and it told me:
"This completion block is executed right after the presentation animation completes, not when the dialog is dismissed."

which sounds right. But I expect you will see this :-)

Version 0.3.0

@mirzemehdi mirzemehdi added the bug Something isn't working label May 11, 2024
@mirzemehdi mirzemehdi self-assigned this May 11, 2024
@mirzemehdi mirzemehdi linked a pull request May 12, 2024 that will close this issue
@mirzemehdi mirzemehdi added this to the 0.3.1 milestone May 12, 2024
@mirzemehdi
Copy link
Owner

@realcbnewham fixed in version 0.3.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants