Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension import: type 'Null' is not a subtype of type 'String' in type cast (@license) #307

Open
2 tasks done
cweiske opened this issue Nov 21, 2024 · 2 comments
Open
2 tasks done
Labels
help wanted Extra attention is needed

Comments

@cweiske
Copy link

cweiske commented Nov 21, 2024

Brief summary

I'm following the "getting started" guide to write my own extension: https://miru.js.org/en/developer/2-extension/

When doing that, I get an error when importing the extension:

type 'Null' is not a subtype of type 'String' in type cast

Steps to reproduce

  1. Create extension.js file
  2. Add meta data as described on https://miru.js.org/en/developer/2-extension/#write-metadata
  3. Import extension
  4. Get error

It fails when loading the "license" meta tag. This is missing from the documentation.

Miru version

v1.8.1-22-g8599d0d

Device

Debian Linux

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • If this is an issue with a extension, I should be opening an issue in the extension repository.
@cweiske cweiske added the help wanted Extra attention is needed label Nov 21, 2024
@OshekharO
Copy link
Member

OshekharO commented Nov 21, 2024

@cweiske Can you mention the website you trying to make extension out of? And also the particular code of section where you are getting null type error?

Or you can continue the conversation here also https://t.me/MiruChat

@cweiske
Copy link
Author

cweiske commented Nov 21, 2024

It fails when loading the "license" meta tag. This is missing from the documentation.

The documentation does not say that the @license meta data is required. This is what needs to be fixed.

After adding the @license meta data line the error disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants