Skip to content

Commit 31ef7c1

Browse files
pillo79dpgeorge
authored andcommitted
esp32: Collect properties from IDF-managed components as well.
Some targets like the ESP32-S3 use the IDF Component Manager to provide additional dependencies to the build. Make sure to include these extra components when collecting properties used by MicroPython-specific build steps, like qstr preprocessing. Signed-off-by: Luca Burelli <[email protected]>
1 parent 4548928 commit 31ef7c1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

ports/esp32/esp32_common.cmake

+3-2
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,9 @@ target_include_directories(${MICROPY_TARGET} PUBLIC
191191
target_link_libraries(${MICROPY_TARGET} micropy_extmod_btree)
192192
target_link_libraries(${MICROPY_TARGET} usermod)
193193

194-
# Collect all of the include directories and compile definitions for the IDF components.
195-
foreach(comp ${IDF_COMPONENTS})
194+
# Collect all of the include directories and compile definitions for the IDF components,
195+
# including those added by the IDF Component Manager via idf_components.yaml.
196+
foreach(comp ${__COMPONENT_NAMES_RESOLVED})
196197
micropy_gather_target_properties(__idf_${comp})
197198
micropy_gather_target_properties(${comp})
198199
endforeach()

0 commit comments

Comments
 (0)