From e05b66877dde7dd431d50ece26d8897d69abc614 Mon Sep 17 00:00:00 2001
From: Nicolas Langheit <35898659+nlangheit@users.noreply.github.com>
Date: Fri, 15 Mar 2024 15:57:46 -0400
Subject: [PATCH] Add locally parameter to pop (#1)

* Add same parameter to pop then in push

* update minor version

* api dump
---
 gradle.properties                                           | 2 +-
 navigation/common/api/navigation.api                        | 5 +++--
 .../pilot/navigation/DefaultPilotNavigationManager.kt       | 6 +++++-
 .../com/mirego/pilot/navigation/PilotNavigationManager.kt   | 2 +-
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/gradle.properties b/gradle.properties
index 6206313..9d2ee21 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -4,4 +4,4 @@ android.enableJetifier=true
 android.useAndroidX=true
 kotlin.native.cacheKind=none
 kotlin.mpp.stability.nowarn=true
-version=0.1.1-SNAPSHOT
+version=0.2.0
diff --git a/navigation/common/api/navigation.api b/navigation/common/api/navigation.api
index 73c852a..041f4eb 100644
--- a/navigation/common/api/navigation.api
+++ b/navigation/common/api/navigation.api
@@ -5,7 +5,7 @@ public class com/mirego/pilot/navigation/DefaultPilotNavigationManager : com/mir
 	public fun currentRoutes ()Ljava/util/List;
 	public fun findRoute (Ljava/lang/String;)Lcom/mirego/pilot/navigation/PilotNavigationRoute;
 	public fun handleAction (Ljava/lang/Object;)V
-	public fun pop ()V
+	public fun pop (Z)V
 	public fun popToId (Ljava/lang/String;Z)V
 	public fun popToName (Ljava/lang/String;Z)V
 	public fun popToRoot ()V
@@ -43,7 +43,8 @@ public abstract class com/mirego/pilot/navigation/PilotNavigationManager {
 	public final fun getActionListener ()Lcom/mirego/pilot/navigation/PilotActionNavigationListener;
 	public final fun getListener ()Lcom/mirego/pilot/navigation/PilotNavigationListener;
 	public abstract fun handleAction (Ljava/lang/Object;)V
-	public abstract fun pop ()V
+	public abstract fun pop (Z)V
+	public static synthetic fun pop$default (Lcom/mirego/pilot/navigation/PilotNavigationManager;ZILjava/lang/Object;)V
 	public abstract fun popToId (Ljava/lang/String;Z)V
 	public abstract fun popToName (Ljava/lang/String;Z)V
 	public abstract fun popToRoot ()V
diff --git a/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/DefaultPilotNavigationManager.kt b/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/DefaultPilotNavigationManager.kt
index 0afb406..6679bcf 100644
--- a/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/DefaultPilotNavigationManager.kt
+++ b/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/DefaultPilotNavigationManager.kt
@@ -29,7 +29,11 @@ public open class DefaultPilotNavigationManager<ROUTE : PilotNavigationRoute, AC
         }
     }
 
-    override fun pop() {
+    override fun pop(locally: Boolean) {
+        if (!locally && parentNavigationManager != null) {
+            parentNavigationManager.pop(locally = locally)
+            return
+        }
         internalPop(callListener = true)
     }
 
diff --git a/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/PilotNavigationManager.kt b/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/PilotNavigationManager.kt
index 692bf39..1ba68b2 100644
--- a/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/PilotNavigationManager.kt
+++ b/navigation/common/src/commonMain/kotlin/com/mirego/pilot/navigation/PilotNavigationManager.kt
@@ -6,7 +6,7 @@ public abstract class PilotNavigationManager<ROUTE : PilotNavigationRoute, ACTIO
     public abstract fun <T : ROUTE> findRoute(uniqueId: String): T?
 
     public abstract fun push(route: ROUTE, locally: Boolean = false)
-    public abstract fun pop()
+    public abstract fun pop(locally: Boolean = false)
     public abstract fun popToId(uniqueId: String, inclusive: Boolean)
     public abstract fun popToName(name: String, inclusive: Boolean)
     public abstract fun popToRoot()