You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm opening this issue to ask if a new config option extraHeaders would be interesting. In our setup (behind Cloudflare Access) any programmatic access needs to provide two extra headers, provided as environment variables to the Docker container. In an effort to get rid of our mitm proxy in CI that just adds the headers to all requests, I was instead looking at a native solution.
To me it looked like the only place this needs to be added (in the CLI, since all the rest is inside the docker container that is the application behind Access) is here in project-fetcher.ts:
and a few places in document.ts - in this second case the simplest solution would be to (add it to config, pass it the Document class) and add it the the private authorizationHeader() method:
Hi 👋,
I'm opening this issue to ask if a new config option
extraHeaders
would be interesting. In our setup (behind Cloudflare Access) any programmatic access needs to provide two extra headers, provided as environment variables to the Docker container. In an effort to get rid of our mitm proxy in CI that just adds the headers to all requests, I was instead looking at a native solution.To me it looked like the only place this needs to be added (in the CLI, since all the rest is inside the docker container that is the application behind Access) is here in
project-fetcher.ts
:accent/cli/src/services/project-fetcher.ts
Lines 114 to 121 in 58b78e2
document.ts
- in this second case the simplest solution would be to (add it to config, pass it the Document class) and add it the theprivate authorizationHeader()
method:accent/cli/src/services/document.ts
Lines 248 to 250 in 58b78e2
fetch()
could all be modified, which one would be preferable?In general, would this extra headers feature be something you would be interested in supporting? Happy to work on a PR implementing it.
The text was updated successfully, but these errors were encountered: